sctp: allow increasing cwnd regardless of ctsn moving or not
As per RFC4960 Errata 3.22, this condition is not needed anymore as it could cause the partial_bytes_acked to not consider the TSNs acked in the Gap Ack Blocks although they were received by the peer successfully. This patch thus drops the check for new Cumulative TSN Ack Point, leaving just the flight_size < cwnd one. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-rfc4960-errata-01#section-3.22 Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
d0b53f4097
commit
e56f777af8
|
@ -406,11 +406,10 @@ void sctp_transport_raise_cwnd(struct sctp_transport *transport,
|
||||||
asoc->fast_recovery = 0;
|
asoc->fast_recovery = 0;
|
||||||
|
|
||||||
/* The appropriate cwnd increase algorithm is performed if, and only
|
/* The appropriate cwnd increase algorithm is performed if, and only
|
||||||
* if the cumulative TSN whould advanced and the congestion window is
|
* if the congestion window is being fully utilized.
|
||||||
* being fully utilized.
|
* Note that RFC4960 Errata 3.22 removed the other condition.
|
||||||
*/
|
*/
|
||||||
if (TSN_lte(sack_ctsn, transport->asoc->ctsn_ack_point) ||
|
if (flight_size < cwnd)
|
||||||
(flight_size < cwnd))
|
|
||||||
return;
|
return;
|
||||||
|
|
||||||
ssthresh = transport->ssthresh;
|
ssthresh = transport->ssthresh;
|
||||||
|
@ -446,11 +445,11 @@ void sctp_transport_raise_cwnd(struct sctp_transport *transport,
|
||||||
flight_size, pba);
|
flight_size, pba);
|
||||||
} else {
|
} else {
|
||||||
/* RFC 2960 7.2.2 Whenever cwnd is greater than ssthresh,
|
/* RFC 2960 7.2.2 Whenever cwnd is greater than ssthresh,
|
||||||
* upon each SACK arrival that advances the Cumulative TSN Ack
|
* upon each SACK arrival, increase partial_bytes_acked
|
||||||
* Point, increase partial_bytes_acked by the total number of
|
* by the total number of bytes of all new chunks
|
||||||
* bytes of all new chunks acknowledged in that SACK including
|
* acknowledged in that SACK including chunks
|
||||||
* chunks acknowledged by the new Cumulative TSN Ack and by
|
* acknowledged by the new Cumulative TSN Ack and by Gap
|
||||||
* Gap Ack Blocks.
|
* Ack Blocks. (updated by RFC4960 Errata 3.22)
|
||||||
*
|
*
|
||||||
* When partial_bytes_acked is equal to or greater than
|
* When partial_bytes_acked is equal to or greater than
|
||||||
* cwnd and before the arrival of the SACK the sender
|
* cwnd and before the arrival of the SACK the sender
|
||||||
|
|
Loading…
Reference in New Issue