misc: mic/scif: fix error code in scif_create_remote_lookup()
We should be returning -ENOMEM here instead of success.
Fixes: ba612aa8b4
('misc: mic: SCIF memory registration and unregistration')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ff65212cc4
commit
e426115e0a
|
@ -386,16 +386,20 @@ static int scif_create_remote_lookup(struct scif_dev *remote_dev,
|
|||
remote_dev, window->nr_lookup *
|
||||
sizeof(*window->dma_addr_lookup.lookup),
|
||||
GFP_KERNEL | __GFP_ZERO);
|
||||
if (!window->dma_addr_lookup.lookup)
|
||||
if (!window->dma_addr_lookup.lookup) {
|
||||
err = -ENOMEM;
|
||||
goto error_window;
|
||||
}
|
||||
|
||||
window->num_pages_lookup.lookup =
|
||||
scif_alloc_coherent(&window->num_pages_lookup.offset,
|
||||
remote_dev, window->nr_lookup *
|
||||
sizeof(*window->num_pages_lookup.lookup),
|
||||
GFP_KERNEL | __GFP_ZERO);
|
||||
if (!window->num_pages_lookup.lookup)
|
||||
if (!window->num_pages_lookup.lookup) {
|
||||
err = -ENOMEM;
|
||||
goto error_window;
|
||||
}
|
||||
|
||||
vmalloc_dma_phys = is_vmalloc_addr(&window->dma_addr[0]);
|
||||
vmalloc_num_pages = is_vmalloc_addr(&window->num_pages[0]);
|
||||
|
|
Loading…
Reference in New Issue