drm/i915/gen9: Clean up MOCS table definitions
Use named struct initializers for clarity. Also fix the target cache definition to reflect its role in GEN9 onwards. On GEN8 a TC value of 0 meant ELLC but on GEN9+ it means the TC and LRU controls are taken from the PTE. No functional change, igt/gem_mocs_settings still passing after this change. v2: (Chris) - Add back the hexa literals for the entries. Add note that igt/gem_mocs_settings still passes. CC: Rong R Yang <rong.r.yang@intel.com> CC: Yakui Zhao <yakui.zhao@intel.com> CC: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Imre Deak <imre.deak@intel.com> Acked-by: Zhao Yakui <yakui.zhao@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1467380406-11954-2-git-send-email-imre.deak@intel.com
This commit is contained in:
parent
62f90b38f3
commit
e419899b7c
|
@ -66,9 +66,10 @@ struct drm_i915_mocs_table {
|
||||||
#define L3_WB 3
|
#define L3_WB 3
|
||||||
|
|
||||||
/* Target cache */
|
/* Target cache */
|
||||||
#define ELLC 0
|
#define LE_TC_PAGETABLE 0
|
||||||
#define LLC 1
|
#define LE_TC_LLC 1
|
||||||
#define LLC_ELLC 2
|
#define LE_TC_LLC_ELLC 2
|
||||||
|
#define LE_TC_LLC_ELLC_ALT 3
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* MOCS tables
|
* MOCS tables
|
||||||
|
@ -96,34 +97,67 @@ struct drm_i915_mocs_table {
|
||||||
* end.
|
* end.
|
||||||
*/
|
*/
|
||||||
static const struct drm_i915_mocs_entry skylake_mocs_table[] = {
|
static const struct drm_i915_mocs_entry skylake_mocs_table[] = {
|
||||||
/* { 0x00000009, 0x0010 } */
|
{ /* 0x00000009 */
|
||||||
{ (LE_CACHEABILITY(LE_UC) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(0) |
|
.control_value = LE_CACHEABILITY(LE_UC) |
|
||||||
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
LE_TGT_CACHE(LE_TC_LLC_ELLC) |
|
||||||
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_UC)) },
|
LE_LRUM(0) | LE_AOM(0) | LE_RSC(0) | LE_SCC(0) |
|
||||||
/* { 0x00000038, 0x0030 } */
|
LE_PFM(0) | LE_SCF(0),
|
||||||
{ (LE_CACHEABILITY(LE_PAGETABLE) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
|
||||||
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
/* 0x0010 */
|
||||||
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) },
|
.l3cc_value = L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_UC),
|
||||||
/* { 0x0000003b, 0x0030 } */
|
},
|
||||||
{ (LE_CACHEABILITY(LE_WB) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
{
|
||||||
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
/* 0x00000038 */
|
||||||
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) }
|
.control_value = LE_CACHEABILITY(LE_PAGETABLE) |
|
||||||
|
LE_TGT_CACHE(LE_TC_LLC_ELLC) |
|
||||||
|
LE_LRUM(3) | LE_AOM(0) | LE_RSC(0) | LE_SCC(0) |
|
||||||
|
LE_PFM(0) | LE_SCF(0),
|
||||||
|
/* 0x0030 */
|
||||||
|
.l3cc_value = L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
/* 0x0000003b */
|
||||||
|
.control_value = LE_CACHEABILITY(LE_WB) |
|
||||||
|
LE_TGT_CACHE(LE_TC_LLC_ELLC) |
|
||||||
|
LE_LRUM(3) | LE_AOM(0) | LE_RSC(0) | LE_SCC(0) |
|
||||||
|
LE_PFM(0) | LE_SCF(0),
|
||||||
|
/* 0x0030 */
|
||||||
|
.l3cc_value = L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB),
|
||||||
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
/* NOTE: the LE_TGT_CACHE is not used on Broxton */
|
/* NOTE: the LE_TGT_CACHE is not used on Broxton */
|
||||||
static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
|
static const struct drm_i915_mocs_entry broxton_mocs_table[] = {
|
||||||
/* { 0x00000009, 0x0010 } */
|
{
|
||||||
{ (LE_CACHEABILITY(LE_UC) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(0) |
|
/* 0x00000009 */
|
||||||
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
.control_value = LE_CACHEABILITY(LE_UC) |
|
||||||
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_UC)) },
|
LE_TGT_CACHE(LE_TC_LLC_ELLC) |
|
||||||
/* { 0x00000038, 0x0030 } */
|
LE_LRUM(0) | LE_AOM(0) | LE_RSC(0) | LE_SCC(0) |
|
||||||
{ (LE_CACHEABILITY(LE_PAGETABLE) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
LE_PFM(0) | LE_SCF(0),
|
||||||
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
|
||||||
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) },
|
/* 0x0010 */
|
||||||
/* { 0x0000003b, 0x0030 } */
|
.l3cc_value = L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_UC),
|
||||||
{ (LE_CACHEABILITY(LE_WB) | LE_TGT_CACHE(LLC_ELLC) | LE_LRUM(3) |
|
},
|
||||||
LE_AOM(0) | LE_RSC(0) | LE_SCC(0) | LE_PFM(0) | LE_SCF(0)),
|
{
|
||||||
(L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB)) }
|
/* 0x00000038 */
|
||||||
|
.control_value = LE_CACHEABILITY(LE_PAGETABLE) |
|
||||||
|
LE_TGT_CACHE(LE_TC_LLC_ELLC) |
|
||||||
|
LE_LRUM(3) | LE_AOM(0) | LE_RSC(0) | LE_SCC(0) |
|
||||||
|
LE_PFM(0) | LE_SCF(0),
|
||||||
|
|
||||||
|
/* 0x0030 */
|
||||||
|
.l3cc_value = L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
/* 0x0000003b */
|
||||||
|
.control_value = LE_CACHEABILITY(LE_WB) |
|
||||||
|
LE_TGT_CACHE(LE_TC_LLC_ELLC) |
|
||||||
|
LE_LRUM(3) | LE_AOM(0) | LE_RSC(0) | LE_SCC(0) |
|
||||||
|
LE_PFM(0) | LE_SCF(0),
|
||||||
|
|
||||||
|
/* 0x0030 */
|
||||||
|
.l3cc_value = L3_ESC(0) | L3_SCC(0) | L3_CACHEABILITY(L3_WB),
|
||||||
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in New Issue