UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ASoC: bcm: cygnus-pcm: Unneeded variable: "ret". 

This patch fixes below issues reported by coccicheck

sound/soc/bcm/cygnus-pcm.c:642:5-8: Unneeded variable: "ret". Return "0"
on line 650
sound/soc/bcm/cygnus-pcm.c:671:5-8: Unneeded variable: "ret". Return "0"
on line 696

We cannot change return type of these functions as they are callback
functions of snd_pcm_ops

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Link: https://lore.kernel.org/r/20190709184236.GA7873@hari-Inspiron-1545
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Hariprasad Kelam 2019-07-10 00:12:37 +05:30 committed by Mark Brown
parent 1d3dd53288
commit e1fb714bdd
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sound/soc/bcm/cygnus-pcm.c
View File

@ -639,7 +639,6 @@ static int cygnus_pcm_hw_params(struct snd_pcm_substream *substream,
struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_pcm_runtime *runtime = substream->runtime; struct snd_pcm_runtime *runtime = substream->runtime;
struct cygnus_aio_port *aio; struct cygnus_aio_port *aio;
int ret = 0;
aio = cygnus_dai_get_dma_data(substream); aio = cygnus_dai_get_dma_data(substream);
dev_dbg(rtd->cpu_dai->dev, "%s port %d\n", __func__, aio->portnum); dev_dbg(rtd->cpu_dai->dev, "%s port %d\n", __func__, aio->portnum);
@ -647,7 +646,7 @@ static int cygnus_pcm_hw_params(struct snd_pcm_substream *substream,
snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer); snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer);
runtime->dma_bytes = params_buffer_bytes(params); runtime->dma_bytes = params_buffer_bytes(params);
return ret; return 0;
} }
static int cygnus_pcm_hw_free(struct snd_pcm_substream *substream) static int cygnus_pcm_hw_free(struct snd_pcm_substream *substream)
@ -668,7 +667,6 @@ static int cygnus_pcm_prepare(struct snd_pcm_substream *substream)
struct snd_pcm_runtime *runtime = substream->runtime; struct snd_pcm_runtime *runtime = substream->runtime;
struct cygnus_aio_port *aio; struct cygnus_aio_port *aio;
unsigned long bufsize, periodsize; unsigned long bufsize, periodsize;
int ret = 0;
bool is_play; bool is_play;
u32 start; u32 start;
struct ringbuf_regs *p_rbuf = NULL; struct ringbuf_regs *p_rbuf = NULL;
@ -693,7 +691,7 @@ static int cygnus_pcm_prepare(struct snd_pcm_substream *substream)
ringbuf_set_initial(aio->cygaud->audio, p_rbuf, is_play, start, ringbuf_set_initial(aio->cygaud->audio, p_rbuf, is_play, start,
periodsize, bufsize); periodsize, bufsize);
return ret; return 0;
} }
static snd_pcm_uframes_t cygnus_pcm_pointer(struct snd_pcm_substream *substream) static snd_pcm_uframes_t cygnus_pcm_pointer(struct snd_pcm_substream *substream)