From e09caaf913a9d3d7fc892c0b5a85e6b2ec3728dc Mon Sep 17 00:00:00 2001
From: Qu Wenruo <wqu@suse.com>
Date: Fri, 13 Nov 2020 20:51:29 +0800
Subject: [PATCH] btrfs: introduce helper to handle page status update in
end_bio_extent_readpage()
Introduce a new helper to handle update page status in
end_bio_extent_readpage(). This will be later used for subpage support
where the page status update can be more complex than now.
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/extent_io.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 519f74502a3e..4bc6beaff562 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2842,6 +2842,17 @@ update:
processed->uptodate = uptodate;
}
+static void endio_readpage_update_page_status(struct page *page, bool uptodate)
+{
+ if (uptodate) {
+ SetPageUptodate(page);
+ } else {
+ ClearPageUptodate(page);
+ SetPageError(page);
+ }
+ unlock_page(page);
+}
+
/*
* after a readpage IO is done, we need to:
* clear the uptodate bits on error
@@ -2964,14 +2975,11 @@ readpage_ok:
off = offset_in_page(i_size);
if (page->index == end_index && off)
zero_user_segment(page, off, PAGE_SIZE);
- SetPageUptodate(page);
- } else {
- ClearPageUptodate(page);
- SetPageError(page);
}
- unlock_page(page);
offset += len;
+ /* Update page status and unlock */
+ endio_readpage_update_page_status(page, uptodate);
endio_readpage_release_extent(&processed, BTRFS_I(inode),
start, end, uptodate);
}