kcm: Call strp_stop before strp_done in kcm_attach

In kcm_attach strp_done is called when sk_user_data is already
set to fail the attach. strp_done needs the strp to be stopped and
warns if it isn't. Call strp_stop in this case to eliminate the
warning message.

Reported-by: syzbot+88dfb55e4c8b770d86e3@syzkaller.appspotmail.com
Fixes: e557124023 ("kcm: Check if sk_user_data already set in kcm_attach"
Signed-off-by: Tom Herbert <tom@quantonium.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Tom Herbert 2018-02-14 09:22:42 -08:00 committed by David S. Miller
parent 0e47079b6c
commit dff8baa261
1 changed files with 1 additions and 0 deletions

View File

@ -1417,6 +1417,7 @@ static int kcm_attach(struct socket *sock, struct socket *csock,
*/ */
if (csk->sk_user_data) { if (csk->sk_user_data) {
write_unlock_bh(&csk->sk_callback_lock); write_unlock_bh(&csk->sk_callback_lock);
strp_stop(&psock->strp);
strp_done(&psock->strp); strp_done(&psock->strp);
kmem_cache_free(kcm_psockp, psock); kmem_cache_free(kcm_psockp, psock);
return -EALREADY; return -EALREADY;