staging: dwc2: fix potential null pointer access

We were testing hsotg pointer for null after we had already
dereferenced it

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Paul Zimmerman 2013-04-22 14:00:16 -07:00 committed by Greg Kroah-Hartman
parent a9b3ea3dbb
commit ddf58468e0
1 changed files with 6 additions and 6 deletions

View File

@ -217,18 +217,18 @@ static void dwc2_update_frame_list(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh,
struct dwc2_host_chan *chan;
u16 i, j, inc;
if (!hsotg) {
pr_err("hsotg = %p", hsotg);
return;
}
if (!qh->channel) {
dev_err(hsotg->dev, "qh->channel = %p", qh->channel);
return;
}
if (!hsotg) {
dev_err(hsotg->dev, "------hsotg = %p", hsotg);
return;
}
if (!hsotg->frame_list) {
dev_err(hsotg->dev, "-------hsotg->frame_list = %p",
dev_err(hsotg->dev, "hsotg->frame_list = %p",
hsotg->frame_list);
return;
}