UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info 

Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements
however up to UCC_MAX_NUM (8) elements are potentially being written
to it.  Currently we have an array out-of-bounds write error on the
last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in
size.

Addresses-Coverity: ("Out-of-bounds write")
Fixes: c19b6d246a ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Colin Ian King 2020-01-14 14:54:48 +00:00 committed by David S. Miller
parent 5a40420e04
commit ddf4203905
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wan/fsl_ucc_hdlc.c
View File

@ -73,7 +73,7 @@ static struct ucc_tdm_info utdm_primary_info = {
}, },
}; };
static struct ucc_tdm_info utdm_info[MAX_HDLC_NUM]; static struct ucc_tdm_info utdm_info[UCC_MAX_NUM];
static int uhdlc_init(struct ucc_hdlc_private *priv) static int uhdlc_init(struct ucc_hdlc_private *priv)
{ {