dm raid: add missing cleanup in raid_ctr()
If rs_prepare_reshape() fails, no cleanup is executed, leading to
leak of the raid_set structure allocated at the beginning of
raid_ctr(). To fix this issue, go to the label 'bad' if the error
occurs.
Fixes: 11e4723206
("dm raid: stop keeping raid set frozen altogether")
Cc: stable@vger.kernel.org
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
parent
e0702d90b7
commit
dc1a3e8e0c
|
@ -3194,7 +3194,7 @@ static int raid_ctr(struct dm_target *ti, unsigned int argc, char **argv)
|
||||||
*/
|
*/
|
||||||
r = rs_prepare_reshape(rs);
|
r = rs_prepare_reshape(rs);
|
||||||
if (r)
|
if (r)
|
||||||
return r;
|
goto bad;
|
||||||
|
|
||||||
/* Reshaping ain't recovery, so disable recovery */
|
/* Reshaping ain't recovery, so disable recovery */
|
||||||
rs_setup_recovery(rs, MaxSector);
|
rs_setup_recovery(rs, MaxSector);
|
||||||
|
|
Loading…
Reference in New Issue