UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

btrfs: avoid reusing return variable in nested block in btrfs_lookup_bio_sums 

The function btrfs_lookup_bio_sums() and a nested if statement declare
ret respectively as blk_status_t and int.

There is no need to store the return value of
search_file_offset_in_bio() to ret as this is a one-time call.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Anand Jain 2023-02-11 00:15:54 +08:00 committed by David Sterba
parent fa13661c48
commit da8269a3e9
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/btrfs/file-item.c
View File

@ -494,12 +494,11 @@ blk_status_t btrfs_lookup_bio_sums(struct btrfs_bio *bbio)
if (inode->root->root_key.objectid == if (inode->root->root_key.objectid ==
BTRFS_DATA_RELOC_TREE_OBJECTID) { BTRFS_DATA_RELOC_TREE_OBJECTID) {
u64 file_offset; u64 file_offset;
int ret;
ret = search_file_offset_in_bio(bio, if (search_file_offset_in_bio(bio,
&inode->vfs_inode, &inode->vfs_inode,
cur_disk_bytenr, &file_offset); cur_disk_bytenr,
if (ret) &file_offset))
set_extent_bits(io_tree, file_offset, set_extent_bits(io_tree, file_offset,
file_offset + sectorsize - 1, file_offset + sectorsize - 1,
EXTENT_NODATASUM); EXTENT_NODATASUM);