UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

s3c-hsudc: Fix possible nullpointer dereference during probe 

The usb-interrupt is requested before the endpoints are initalised.
If an interrupt happens in the time between request_irq and the init
of the endpoint-data (as seen on the Qisda ESx00 ebook-platforms),
it is therefore possible for the interrupt handler to access endpoint-
data before its creation resulting in a null-pointer dereference.

This patch simply moves the irq request below the endpoint init.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Heiko Stübner 2011-08-21 14:31:17 +02:00 committed by Greg Kroah-Hartman
parent 94ab23dd25
commit da4fc14c99
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/usb/gadget/s3c-hsudc.c
View File

@ -1269,19 +1269,6 @@ static int s3c_hsudc_probe(struct platform_device *pdev)
goto err_remap; goto err_remap;
} }
ret = platform_get_irq(pdev, 0);
if (ret < 0) {
dev_err(dev, "unable to obtain IRQ number\n");
goto err_irq;
}
hsudc->irq = ret;
ret = request_irq(hsudc->irq, s3c_hsudc_irq, 0, driver_name, hsudc);
if (ret < 0) {
dev_err(dev, "irq request failed\n");
goto err_irq;
}
spin_lock_init(&hsudc->lock); spin_lock_init(&hsudc->lock);
device_initialize(&hsudc->gadget.dev); device_initialize(&hsudc->gadget.dev);
@ -1299,6 +1286,19 @@ static int s3c_hsudc_probe(struct platform_device *pdev)
s3c_hsudc_setup_ep(hsudc); s3c_hsudc_setup_ep(hsudc);
ret = platform_get_irq(pdev, 0);
if (ret < 0) {
dev_err(dev, "unable to obtain IRQ number\n");
goto err_irq;
}
hsudc->irq = ret;
ret = request_irq(hsudc->irq, s3c_hsudc_irq, 0, driver_name, hsudc);
if (ret < 0) {
dev_err(dev, "irq request failed\n");
goto err_irq;
}
hsudc->uclk = clk_get(&pdev->dev, "usb-device"); hsudc->uclk = clk_get(&pdev->dev, "usb-device");
if (IS_ERR(hsudc->uclk)) { if (IS_ERR(hsudc->uclk)) {
dev_err(dev, "failed to find usb-device clock source\n"); dev_err(dev, "failed to find usb-device clock source\n");