UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: pci: cobalt: Replace GFP_ATOMIC with GFP_KERNEL in cobalt_probe() 

cobalt_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Jia-Ju Bai 2018-07-26 23:07:04 -04:00 committed by Mauro Carvalho Chehab
parent a8a4d304b1
commit da27ef6875
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/pci/cobalt/cobalt-driver.c
View File

@ -670,7 +670,7 @@ static int cobalt_probe(struct pci_dev *pci_dev,
/* FIXME - module parameter arrays constrain max instances */ /* FIXME - module parameter arrays constrain max instances */
i = atomic_inc_return(&cobalt_instance) - 1; i = atomic_inc_return(&cobalt_instance) - 1;
cobalt = kzalloc(sizeof(struct cobalt), GFP_ATOMIC); cobalt = kzalloc(sizeof(struct cobalt), GFP_KERNEL);
if (cobalt == NULL) if (cobalt == NULL)
return -ENOMEM; return -ENOMEM;
cobalt->pci_dev = pci_dev; cobalt->pci_dev = pci_dev;