UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: switch importing msghdr from userland to {compat_,}import_iovec() 

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2015-03-21 19:29:06 -04:00
parent 602bd0e90e
commit da18428498
3 changed files with 20 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/compat.h
View File

@ -40,7 +40,7 @@ int compat_sock_get_timestampns(struct sock *, struct timespec __user *);
#define compat_mmsghdr mmsghdr #define compat_mmsghdr mmsghdr
#endif /* defined(CONFIG_COMPAT) */ #endif /* defined(CONFIG_COMPAT) */
ssize_t get_compat_msghdr(struct msghdr *, struct compat_msghdr __user *, int get_compat_msghdr(struct msghdr *, struct compat_msghdr __user *,
struct sockaddr __user **, struct iovec **); struct sockaddr __user **, struct iovec **);
asmlinkage long compat_sys_sendmsg(int, struct compat_msghdr __user *, asmlinkage long compat_sys_sendmsg(int, struct compat_msghdr __user *,
unsigned int); unsigned int);

18
net/compat.c
View File

@ -31,10 +31,10 @@
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <net/compat.h> #include <net/compat.h>
ssize_t get_compat_msghdr(struct msghdr *kmsg, int get_compat_msghdr(struct msghdr *kmsg,
struct compat_msghdr __user *umsg, struct compat_msghdr __user *umsg,
struct sockaddr __user **save_addr, struct sockaddr __user **save_addr,
struct iovec **iov) struct iovec **iov)
{ {
compat_uptr_t uaddr, uiov, tmp3; compat_uptr_t uaddr, uiov, tmp3;
compat_size_t nr_segs; compat_size_t nr_segs;
@ -81,13 +81,9 @@ ssize_t get_compat_msghdr(struct msghdr *kmsg,
kmsg->msg_iocb = NULL; kmsg->msg_iocb = NULL;
err = compat_rw_copy_check_uvector(save_addr ? READ : WRITE, return compat_import_iovec(save_addr ? READ : WRITE,
compat_ptr(uiov), nr_segs, compat_ptr(uiov), nr_segs,
UIO_FASTIOV, *iov, iov); UIO_FASTIOV, iov, &kmsg->msg_iter);
if (err >= 0)
iov_iter_init(&kmsg->msg_iter, save_addr ? READ : WRITE,
*iov, nr_segs, err);
return err;
} }
/* Bleech... */ /* Bleech... */

31
net/socket.c
View File

@ -1841,10 +1841,10 @@ struct used_address {
unsigned int name_len; unsigned int name_len;
}; };
static ssize_t copy_msghdr_from_user(struct msghdr *kmsg, static int copy_msghdr_from_user(struct msghdr *kmsg,
struct user_msghdr __user *umsg, struct user_msghdr __user *umsg,
struct sockaddr __user **save_addr, struct sockaddr __user **save_addr,
struct iovec **iov) struct iovec **iov)
{ {
struct sockaddr __user *uaddr; struct sockaddr __user *uaddr;
struct iovec __user *uiov; struct iovec __user *uiov;
@ -1890,13 +1890,8 @@ static ssize_t copy_msghdr_from_user(struct msghdr *kmsg,
kmsg->msg_iocb = NULL; kmsg->msg_iocb = NULL;
err = rw_copy_check_uvector(save_addr ? READ : WRITE, return import_iovec(save_addr ? READ : WRITE, uiov, nr_segs,
uiov, nr_segs, UIO_FASTIOV, iov, &kmsg->msg_iter);
UIO_FASTIOV, *iov, iov);
if (err >= 0)
iov_iter_init(&kmsg->msg_iter, save_addr ? READ : WRITE,
*iov, nr_segs, err);
return err;
} }
static int ___sys_sendmsg(struct socket *sock, struct user_msghdr __user *msg, static int ___sys_sendmsg(struct socket *sock, struct user_msghdr __user *msg,
@ -1921,8 +1916,8 @@ static int ___sys_sendmsg(struct socket *sock, struct user_msghdr __user *msg,
else else
err = copy_msghdr_from_user(msg_sys, msg, NULL, &iov); err = copy_msghdr_from_user(msg_sys, msg, NULL, &iov);
if (err < 0) if (err < 0)
goto out_freeiov; return err;
total_len = err; total_len = iov_iter_count(&msg_sys->msg_iter);
err = -ENOBUFS; err = -ENOBUFS;
@ -1988,8 +1983,7 @@ out_freectl:
if (ctl_buf != ctl) if (ctl_buf != ctl)
sock_kfree_s(sock->sk, ctl_buf, ctl_len); sock_kfree_s(sock->sk, ctl_buf, ctl_len);
out_freeiov: out_freeiov:
if (iov != iovstack) kfree(iov);
kfree(iov);
return err; return err;
} }
@ -2114,8 +2108,8 @@ static int ___sys_recvmsg(struct socket *sock, struct user_msghdr __user *msg,
else else
err = copy_msghdr_from_user(msg_sys, msg, &uaddr, &iov); err = copy_msghdr_from_user(msg_sys, msg, &uaddr, &iov);
if (err < 0) if (err < 0)
goto out_freeiov; return err;
total_len = err; total_len = iov_iter_count(&msg_sys->msg_iter);
cmsg_ptr = (unsigned long)msg_sys->msg_control; cmsg_ptr = (unsigned long)msg_sys->msg_control;
msg_sys->msg_flags = flags & (MSG_CMSG_CLOEXEC|MSG_CMSG_COMPAT); msg_sys->msg_flags = flags & (MSG_CMSG_CLOEXEC|MSG_CMSG_COMPAT);
@ -2153,8 +2147,7 @@ static int ___sys_recvmsg(struct socket *sock, struct user_msghdr __user *msg,
err = len; err = len;
out_freeiov: out_freeiov:
if (iov != iovstack) kfree(iov);
kfree(iov);
return err; return err;
} }