ubifs: fix snprintf() length check
The snprintf() function returns the number of bytes (not including the NUL terminator) which would have been printed if there were enough space. So it can be greater than UBIFS_DFS_DIR_LEN. And actually if it equals UBIFS_DFS_DIR_LEN then that's okay so this check is too strict. Fixes: 9a620291fc01 ("ubifs: Export filesystem error counters") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Richard Weinberger <richard@nod.at>
This commit is contained in:
parent
58225631cf
commit
d3de970bcb
|
@ -100,7 +100,7 @@ int ubifs_sysfs_register(struct ubifs_info *c)
|
|||
n = snprintf(dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME,
|
||||
c->vi.ubi_num, c->vi.vol_id);
|
||||
|
||||
if (n == UBIFS_DFS_DIR_LEN) {
|
||||
if (n > UBIFS_DFS_DIR_LEN) {
|
||||
/* The array size is too small */
|
||||
ret = -EINVAL;
|
||||
goto out_free;
|
||||
|
|
Loading…
Reference in New Issue