[media] dvb-usb/friio-fe: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
37320d7bc0
commit
d3a9509184
|
@ -421,11 +421,10 @@ struct dvb_frontend *jdvbt90502_attach(struct dvb_usb_device *d)
|
|||
|
||||
/* setup the state */
|
||||
state->i2c = &d->i2c_adap;
|
||||
memcpy(&state->config, &friio_fe_config, sizeof(friio_fe_config));
|
||||
state->config = friio_fe_config;
|
||||
|
||||
/* create dvb_frontend */
|
||||
memcpy(&state->frontend.ops, &jdvbt90502_ops,
|
||||
sizeof(jdvbt90502_ops));
|
||||
state->frontend.ops = jdvbt90502_ops;
|
||||
state->frontend.demodulator_priv = state;
|
||||
|
||||
if (jdvbt90502_init(&state->frontend) < 0)
|
||||
|
|
Loading…
Reference in New Issue