target: cleanup transport_execute_tasks()
The function is effectively void and doesn't need any goto logic. Signed-off-by: Joern Engel <joern@logfs.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
11e764bd5e
commit
d28d96dcf6
|
@ -1970,7 +1970,7 @@ static inline int transport_execute_task_attr(struct se_cmd *cmd)
|
||||||
* Called from fabric module context in transport_generic_new_cmd() and
|
* Called from fabric module context in transport_generic_new_cmd() and
|
||||||
* transport_generic_process_write()
|
* transport_generic_process_write()
|
||||||
*/
|
*/
|
||||||
static int transport_execute_tasks(struct se_cmd *cmd)
|
static void transport_execute_tasks(struct se_cmd *cmd)
|
||||||
{
|
{
|
||||||
int add_tasks;
|
int add_tasks;
|
||||||
struct se_device *se_dev = cmd->se_dev;
|
struct se_device *se_dev = cmd->se_dev;
|
||||||
|
@ -1984,16 +1984,12 @@ static int transport_execute_tasks(struct se_cmd *cmd)
|
||||||
* attribute for the tasks of the received struct se_cmd CDB
|
* attribute for the tasks of the received struct se_cmd CDB
|
||||||
*/
|
*/
|
||||||
add_tasks = transport_execute_task_attr(cmd);
|
add_tasks = transport_execute_task_attr(cmd);
|
||||||
if (!add_tasks)
|
if (add_tasks) {
|
||||||
goto execute_tasks;
|
__transport_execute_tasks(se_dev, cmd);
|
||||||
|
return;
|
||||||
__transport_execute_tasks(se_dev, cmd);
|
}
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
execute_tasks:
|
|
||||||
__transport_execute_tasks(se_dev, NULL);
|
__transport_execute_tasks(se_dev, NULL);
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static int __transport_execute_tasks(struct se_device *dev, struct se_cmd *new_cmd)
|
static int __transport_execute_tasks(struct se_device *dev, struct se_cmd *new_cmd)
|
||||||
|
|
Loading…
Reference in New Issue