iommu/arm-smmu: Error out only if not enough context interrupts
Currently we check if the number of context banks is not equal to num_context_interrupts. However, there are booloaders such as, one on sdm845 that reserves few context banks and thus kernel views less than the total available context banks. So, although the hardware definition in device tree would mention the correct number of context interrupts, this number can be greater than the number of context banks visible to smmu in kernel. We should therefore error out only when the number of context banks is greater than the available number of context interrupts. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> Suggested-by: Tomasz Figa <tfiga@chromium.org> Cc: Robin Murphy <robin.murphy@arm.com> Cc: Will Deacon <will.deacon@arm.com> [will: drop useless printk] Signed-off-by: Will Deacon <will.deacon@arm.com>
This commit is contained in:
parent
29859aeb8a
commit
d1e20222d5
|
@ -2103,14 +2103,18 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
|
||||||
if (err)
|
if (err)
|
||||||
return err;
|
return err;
|
||||||
|
|
||||||
if (smmu->version == ARM_SMMU_V2 &&
|
if (smmu->version == ARM_SMMU_V2) {
|
||||||
smmu->num_context_banks != smmu->num_context_irqs) {
|
if (smmu->num_context_banks > smmu->num_context_irqs) {
|
||||||
dev_err(dev,
|
dev_err(dev,
|
||||||
"found only %d context interrupt(s) but %d required\n",
|
"found only %d context irq(s) but %d required\n",
|
||||||
smmu->num_context_irqs, smmu->num_context_banks);
|
smmu->num_context_irqs, smmu->num_context_banks);
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Ignore superfluous interrupts */
|
||||||
|
smmu->num_context_irqs = smmu->num_context_banks;
|
||||||
|
}
|
||||||
|
|
||||||
for (i = 0; i < smmu->num_global_irqs; ++i) {
|
for (i = 0; i < smmu->num_global_irqs; ++i) {
|
||||||
err = devm_request_irq(smmu->dev, smmu->irqs[i],
|
err = devm_request_irq(smmu->dev, smmu->irqs[i],
|
||||||
arm_smmu_global_fault,
|
arm_smmu_global_fault,
|
||||||
|
|
Loading…
Reference in New Issue