UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

backlight: gpio: Use a helper variable for &pdev->dev 

Instead of dereferencing pdev each time, use a helper variable for
the associated device pointer.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Bartosz Golaszewski 2019-10-22 10:36:29 +02:00 committed by Lee Jones
parent 2e7ec69d64
commit d17465a0af
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/video/backlight/gpio_backlight.c
View File

@ -78,29 +78,29 @@ static int gpio_backlight_initial_power_state(struct gpio_backlight *gbl)
static int gpio_backlight_probe(struct platform_device *pdev) static int gpio_backlight_probe(struct platform_device *pdev)
{ {
struct gpio_backlight_platform_data *pdata = struct device *dev = &pdev->dev;
dev_get_platdata(&pdev->dev); struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);
struct backlight_properties props; struct backlight_properties props;
struct backlight_device *bl; struct backlight_device *bl;
struct gpio_backlight *gbl; struct gpio_backlight *gbl;
int ret, init_brightness; int ret, init_brightness;
gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL); gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
if (gbl == NULL) if (gbl == NULL)
return -ENOMEM; return -ENOMEM;
gbl->dev = &pdev->dev; gbl->dev = dev;
if (pdata) if (pdata)
gbl->fbdev = pdata->fbdev; gbl->fbdev = pdata->fbdev;
gbl->def_value = device_property_read_bool(&pdev->dev, "default-on"); gbl->def_value = device_property_read_bool(dev, "default-on");
gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, GPIOD_ASIS); gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
if (IS_ERR(gbl->gpiod)) { if (IS_ERR(gbl->gpiod)) {
ret = PTR_ERR(gbl->gpiod); ret = PTR_ERR(gbl->gpiod);
if (ret != -EPROBE_DEFER) if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev, dev_err(dev,
"Error: The gpios parameter is missing or invalid.\n"); "Error: The gpios parameter is missing or invalid.\n");
return ret; return ret;
} }
@ -108,11 +108,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(props)); memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW; props.type = BACKLIGHT_RAW;
props.max_brightness = 1; props.max_brightness = 1;
bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev), bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
&pdev->dev, gbl, &gpio_backlight_ops, &gpio_backlight_ops, &props);
&props);
if (IS_ERR(bl)) { if (IS_ERR(bl)) {
dev_err(&pdev->dev, "failed to register backlight\n"); dev_err(dev, "failed to register backlight\n");
return PTR_ERR(bl); return PTR_ERR(bl);
} }
@ -122,7 +121,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
init_brightness = gpio_backlight_get_next_brightness(bl); init_brightness = gpio_backlight_get_next_brightness(bl);
ret = gpiod_direction_output(gbl->gpiod, init_brightness); ret = gpiod_direction_output(gbl->gpiod, init_brightness);
if (ret) { if (ret) {
dev_err(&pdev->dev, "failed to set initial brightness\n"); dev_err(dev, "failed to set initial brightness\n");
return ret; return ret;
} }