eth: r8152: try to use a normal budget
Mario reports that loading r8152 on his system leads to a: netif_napi_add_weight() called with weight 256 warning getting printed. We don't have any solid data on why such high budget was chosen, and it may cause stalls in processing other softirqs and rt threads. So try to switch back to the default (64) weight. If this slows down someone's system we should investigate which part of stopping starting the NAPI poll in this driver are expensive. Reported-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/all/0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com/ Acked-by: Hayes Wang <hayeswang@realtek.com> Link: https://lore.kernel.org/r/20230814153521.2697982-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
3bfdcc324a
commit
cf74eb5a5b
|
@ -9760,8 +9760,7 @@ static int rtl8152_probe(struct usb_interface *intf,
|
|||
|
||||
usb_set_intfdata(intf, tp);
|
||||
|
||||
netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
|
||||
tp->support_2500full ? 256 : 64);
|
||||
netif_napi_add(netdev, &tp->napi, r8152_poll);
|
||||
|
||||
ret = register_netdev(netdev);
|
||||
if (ret != 0) {
|
||||
|
|
Loading…
Reference in New Issue