UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

cxl/pci: Use CXL_MBOX_SUCCESS to check against mbox_cmd return code 

Also mention the need for the caller to check against any
errors from the hardware in return_code.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
Link: https://lore.kernel.org/r/20220404021216.66841-3-dave@stgolabs.net
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Davidlohr Bueso 2022-04-03 19:12:14 -07:00 committed by Dan Williams
parent ee92c7e261
commit cbe83a2052
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/cxl/pci.c
View File

@ -177,9 +177,9 @@ static int __cxl_pci_mbox_send_cmd(struct cxl_dev_state *cxlds,
mbox_cmd->return_code =
FIELD_GET(CXLDEV_MBOX_STATUS_RET_CODE_MASK, status_reg);
if (mbox_cmd->return_code != 0) {
if (mbox_cmd->return_code != CXL_MBOX_SUCCESS) {
dev_dbg(dev, "Mailbox operation had an error\n");
return 0;
return 0; /* completed but caller must check return_code */
}
/* #7 */