UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

gpio: pca953x: Simplify with dev_err_probe() 

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This commit is contained in:
Krzysztof Kozlowski 2020-08-27 22:08:25 +02:00 committed by Bartosz Golaszewski
parent 4e7ed69685
commit ca6a77eb34
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/gpio/gpio-pca953x.c
View File

@ -1000,12 +1000,9 @@ static int pca953x_probe(struct i2c_client *client,
chip->client = client; chip->client = client;
reg = devm_regulator_get(&client->dev, "vcc"); reg = devm_regulator_get(&client->dev, "vcc");
if (IS_ERR(reg)) { if (IS_ERR(reg))
ret = PTR_ERR(reg); return dev_err_probe(&client->dev, PTR_ERR(reg), "reg get err\n");
if (ret != -EPROBE_DEFER)
dev_err(&client->dev, "reg get err: %d\n", ret);
return ret;
}
ret = regulator_enable(reg); ret = regulator_enable(reg);
if (ret) { if (ret) {
dev_err(&client->dev, "reg en err: %d\n", ret); dev_err(&client->dev, "reg en err: %d\n", ret);