UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

Input: raydium_i2c_ts - simplify with dev_err_probe() 

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230625162817.100397-17-krzysztof.kozlowski@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Krzysztof Kozlowski 2023-06-25 18:28:09 +02:00 committed by Dmitry Torokhov
parent e32825c470
commit ca0d9997f5
1 changed files with 9 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
drivers/input/touchscreen/raydium_i2c_ts.c
View File

@ -1087,32 +1087,20 @@ static int raydium_i2c_probe(struct i2c_client *client)
i2c_set_clientdata(client, ts); i2c_set_clientdata(client, ts);
ts->avdd = devm_regulator_get(&client->dev, "avdd"); ts->avdd = devm_regulator_get(&client->dev, "avdd");
if (IS_ERR(ts->avdd)) { if (IS_ERR(ts->avdd))
error = PTR_ERR(ts->avdd); return dev_err_probe(&client->dev, PTR_ERR(ts->avdd),
if (error != -EPROBE_DEFER) "Failed to get 'avdd' regulator\n");
dev_err(&client->dev,
"Failed to get 'avdd' regulator: %d\n", error);
return error;
}
ts->vccio = devm_regulator_get(&client->dev, "vccio"); ts->vccio = devm_regulator_get(&client->dev, "vccio");
if (IS_ERR(ts->vccio)) { if (IS_ERR(ts->vccio))
error = PTR_ERR(ts->vccio); return dev_err_probe(&client->dev, PTR_ERR(ts->vccio),
if (error != -EPROBE_DEFER) "Failed to get 'vccio' regulator\n");
dev_err(&client->dev,
"Failed to get 'vccio' regulator: %d\n", error);
return error;
}
ts->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", ts->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset",
GPIOD_OUT_LOW); GPIOD_OUT_LOW);
if (IS_ERR(ts->reset_gpio)) { if (IS_ERR(ts->reset_gpio))
error = PTR_ERR(ts->reset_gpio); return dev_err_probe(&client->dev, PTR_ERR(ts->reset_gpio),
if (error != -EPROBE_DEFER) "Failed to get reset gpio\n");
dev_err(&client->dev,
"failed to get reset gpio: %d\n", error);
return error;
}
error = raydium_i2c_power_on(ts); error = raydium_i2c_power_on(ts);
if (error) if (error)