UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: lustre: mgc: Use !x to check for kzalloc failure 

!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x == NULL
+ !x
 ) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2015-06-20 18:59:06 +02:00 committed by Greg Kroah-Hartman
parent bb144d09a9
commit c829be8176
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/lustre/lustre/mgc/mgc_request.c
View File

@ -1128,7 +1128,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
LASSERT(cfg->cfg_sb == cfg->cfg_instance); LASSERT(cfg->cfg_sb == cfg->cfg_instance);
inst = kzalloc(PAGE_CACHE_SIZE, GFP_NOFS); inst = kzalloc(PAGE_CACHE_SIZE, GFP_NOFS);
if (inst == NULL) if (!inst)
return -ENOMEM; return -ENOMEM;
if (!IS_SERVER(lsi)) { if (!IS_SERVER(lsi)) {
@ -1493,7 +1493,7 @@ static int mgc_process_cfg_log(struct obd_device *mgc,
lsi = s2lsi(cld->cld_cfg.cfg_sb); lsi = s2lsi(cld->cld_cfg.cfg_sb);
env = kzalloc(sizeof(*env), GFP_NOFS); env = kzalloc(sizeof(*env), GFP_NOFS);
if (env == NULL) if (!env)
return -ENOMEM; return -ENOMEM;
rc = lu_env_init(env, LCT_MG_THREAD); rc = lu_env_init(env, LCT_MG_THREAD);