[media] ite-cir: finish tx before suspending
Continuing with IR transmit after resuming from suspend seems fairly useless, given that the only place we can actually end up suspending is after IR has been send and we're simply mdelay'ing. Lets simplify the resume path by just waiting on tx to complete in the suspend path, then we know we can't be transmitting on resume, and reinitialization of the hardware registers becomes more straight-forward. CC: Juan Jesús García de Soria <skandalfo@gmail.com> Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
f0c1629dca
commit
c812045488
|
@ -1650,6 +1650,9 @@ static int ite_suspend(struct pnp_dev *pdev, pm_message_t state)
|
|||
|
||||
ite_dbg("%s called", __func__);
|
||||
|
||||
/* wait for any transmission to end */
|
||||
wait_event_interruptible(dev->tx_ended, !dev->transmitting);
|
||||
|
||||
spin_lock_irqsave(&dev->lock, flags);
|
||||
|
||||
/* disable all interrupts */
|
||||
|
@ -1670,15 +1673,10 @@ static int ite_resume(struct pnp_dev *pdev)
|
|||
|
||||
spin_lock_irqsave(&dev->lock, flags);
|
||||
|
||||
if (dev->transmitting) {
|
||||
/* wake up the transmitter */
|
||||
wake_up_interruptible(&dev->tx_queue);
|
||||
} else {
|
||||
/* reinitialize hardware config registers */
|
||||
dev->params.init_hardware(dev);
|
||||
/* enable the receiver */
|
||||
dev->params.enable_rx(dev);
|
||||
}
|
||||
/* reinitialize hardware config registers */
|
||||
dev->params.init_hardware(dev);
|
||||
/* enable the receiver */
|
||||
dev->params.enable_rx(dev);
|
||||
|
||||
spin_unlock_irqrestore(&dev->lock, flags);
|
||||
|
||||
|
|
Loading…
Reference in New Issue