Theoretical fix, which greatly simplifies upcoming balloon patches which will go in via some vm tree.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJP+hnqAAoJENkgDmzRrbjxkpcP/jl53FUc6M8L9djVSu/5EIxV 2uLCoGL7kPq2f168VJ4002f1Fa5Irld9h7A4qlqxn8sE/5OGTEvSGnw3/rkoeMeB NLjZAFCre+qN0kWFFeZN76TlTGIJpudjsw4EE5fV8CSEbjSRt4SzQ1r8euRKGc0m 1mqp5rCeUAPrDhRuEyqcqKU36CjDDnNukz1Q1tADgTJ6Q0T8yBZkDqPOIpNy6LCv YfazFiZDox7Wx7abPGJga4mIz1OyUR6l4vD8trJHrUaWlirLZE51+Lf69tAXP+Az lxvCyiXVTuNuj/TI8FOejWdixmMW3GczeSn7KCzbke1GbUfne1DBfxDImdJg6VbG AhQHUqvJAWHuohS5mnJpFCQZIrfkScyXC0gVm+g/dIJTf+4jqirk4DZyHZecznt1 T5FdleRqO2ws0BMxeD3r/d/q5aUR0ryS08CLzFLP0GDcFgU6wANM87G1Q4IahZ7A gUjQ82piy1zzYML3/4r4qPTWAk1BGCYB6yfSVlCSwwhp+U5qER7cvrTugm4/eA6g 4QkDUlGcwGryN6/VSNIoT6ymIB5SpFgOuAcF011MKl9OMUnOyshsiLz3GuTEGYim GZmcJsFnV9rbGTQ2DjYw8fny+DB4wwOTkHjdwVGfKBII3nY4Puc8bzaShqbDj+nH G1VIKLiZPmRVgm4cc5jC =vMWl -----END PGP SIGNATURE----- Merge tag 'virtio-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus Pull minor virtio-balloon fix from Rusty Russell: "Theoretical fix, which greatly simplifies upcoming balloon patches which will go in via some vm tree." * tag 'virtio-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus: virtio-balloon: fix add/get API use
This commit is contained in:
commit
c5e43b83b0
|
@ -47,7 +47,7 @@ struct virtio_balloon
|
|||
struct task_struct *thread;
|
||||
|
||||
/* Waiting for host to ack the pages we released. */
|
||||
struct completion acked;
|
||||
wait_queue_head_t acked;
|
||||
|
||||
/* Number of balloon pages we've told the Host we're not using. */
|
||||
unsigned int num_pages;
|
||||
|
@ -89,29 +89,25 @@ static struct page *balloon_pfn_to_page(u32 pfn)
|
|||
|
||||
static void balloon_ack(struct virtqueue *vq)
|
||||
{
|
||||
struct virtio_balloon *vb;
|
||||
unsigned int len;
|
||||
struct virtio_balloon *vb = vq->vdev->priv;
|
||||
|
||||
vb = virtqueue_get_buf(vq, &len);
|
||||
if (vb)
|
||||
complete(&vb->acked);
|
||||
wake_up(&vb->acked);
|
||||
}
|
||||
|
||||
static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq)
|
||||
{
|
||||
struct scatterlist sg;
|
||||
unsigned int len;
|
||||
|
||||
sg_init_one(&sg, vb->pfns, sizeof(vb->pfns[0]) * vb->num_pfns);
|
||||
|
||||
init_completion(&vb->acked);
|
||||
|
||||
/* We should always be able to add one buffer to an empty queue. */
|
||||
if (virtqueue_add_buf(vq, &sg, 1, 0, vb, GFP_KERNEL) < 0)
|
||||
BUG();
|
||||
virtqueue_kick(vq);
|
||||
|
||||
/* When host has read buffer, this completes via balloon_ack */
|
||||
wait_for_completion(&vb->acked);
|
||||
wait_event(vb->acked, virtqueue_get_buf(vq, &len));
|
||||
}
|
||||
|
||||
static void set_page_pfns(u32 pfns[], struct page *page)
|
||||
|
@ -231,12 +227,8 @@ static void update_balloon_stats(struct virtio_balloon *vb)
|
|||
*/
|
||||
static void stats_request(struct virtqueue *vq)
|
||||
{
|
||||
struct virtio_balloon *vb;
|
||||
unsigned int len;
|
||||
struct virtio_balloon *vb = vq->vdev->priv;
|
||||
|
||||
vb = virtqueue_get_buf(vq, &len);
|
||||
if (!vb)
|
||||
return;
|
||||
vb->need_stats_update = 1;
|
||||
wake_up(&vb->config_change);
|
||||
}
|
||||
|
@ -245,11 +237,14 @@ static void stats_handle_request(struct virtio_balloon *vb)
|
|||
{
|
||||
struct virtqueue *vq;
|
||||
struct scatterlist sg;
|
||||
unsigned int len;
|
||||
|
||||
vb->need_stats_update = 0;
|
||||
update_balloon_stats(vb);
|
||||
|
||||
vq = vb->stats_vq;
|
||||
if (!virtqueue_get_buf(vq, &len))
|
||||
return;
|
||||
sg_init_one(&sg, vb->stats, sizeof(vb->stats));
|
||||
if (virtqueue_add_buf(vq, &sg, 1, 0, vb, GFP_KERNEL) < 0)
|
||||
BUG();
|
||||
|
@ -358,6 +353,7 @@ static int virtballoon_probe(struct virtio_device *vdev)
|
|||
INIT_LIST_HEAD(&vb->pages);
|
||||
vb->num_pages = 0;
|
||||
init_waitqueue_head(&vb->config_change);
|
||||
init_waitqueue_head(&vb->acked);
|
||||
vb->vdev = vdev;
|
||||
vb->need_stats_update = 0;
|
||||
|
||||
|
|
Loading…
Reference in New Issue