UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

backlight: led_bl: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-7-u.kleine-koenig@pengutronix.de
This commit is contained in:
Uwe Kleine-König 2023-03-08 08:39:38 +01:00 committed by Lee Jones
parent 7150f8c2aa
commit c4c4fa57fd
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/video/backlight/led_bl.c
View File

@ -217,7 +217,7 @@ static int led_bl_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int led_bl_remove(struct platform_device *pdev) static void led_bl_remove(struct platform_device *pdev)
{ {
struct led_bl_data *priv = platform_get_drvdata(pdev); struct led_bl_data *priv = platform_get_drvdata(pdev);
struct backlight_device *bl = priv->bl_dev; struct backlight_device *bl = priv->bl_dev;
@ -228,8 +228,6 @@ static int led_bl_remove(struct platform_device *pdev)
led_bl_power_off(priv); led_bl_power_off(priv);
for (i = 0; i < priv->nb_leds; i++) for (i = 0; i < priv->nb_leds; i++)
led_sysfs_enable(priv->leds[i]); led_sysfs_enable(priv->leds[i]);
return 0;
} }
static const struct of_device_id led_bl_of_match[] = { static const struct of_device_id led_bl_of_match[] = {
@ -245,7 +243,7 @@ static struct platform_driver led_bl_driver = {
.of_match_table = of_match_ptr(led_bl_of_match), .of_match_table = of_match_ptr(led_bl_of_match),
}, },
.probe = led_bl_probe, .probe = led_bl_probe,
.remove = led_bl_remove, .remove_new = led_bl_remove,
}; };
module_platform_driver(led_bl_driver); module_platform_driver(led_bl_driver);