UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

accel/habanalabs: don't wait for STS_OK after sending COMMS WFE 

Sending COMMS_GOTO_WFE instructs the FW's CPU to halt (WFE state).
Once sent, FW's CPU isn't expected to continue communicating with LKD.
Therefore, the stage of waiting for COMMS_STS_OK should be skipped or
else waiting for COMMS_STS_OK will simply timeout, which will trigger
unexpected behavior.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
This commit is contained in:
Koby Elbaz 2023-03-26 18:22:57 +03:00 committed by Oded Gabbay
parent 802f25b6c2
commit c19350efa9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/accel/habanalabs/common/firmware_if.c
View File

@ -1278,7 +1278,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev)
/* Stop device CPU to make sure nothing bad happens */ /* Stop device CPU to make sure nothing bad happens */
if (hdev->asic_prop.dynamic_fw_load) { if (hdev->asic_prop.dynamic_fw_load) {
rc = hl_fw_dynamic_send_protocol_cmd(hdev, &hdev->fw_loader, rc = hl_fw_dynamic_send_protocol_cmd(hdev, &hdev->fw_loader,
COMMS_GOTO_WFE, 0, true, COMMS_GOTO_WFE, 0, false,
hdev->fw_loader.cpu_timeout); hdev->fw_loader.cpu_timeout);
if (rc) if (rc)
dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n"); dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n");