UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c 

Using list_move_tail() instead of list_del() + list_add_tail() in ssh_packet_layer.c.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210609072448.1357524-1-libaokun1@huawei.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Baokun Li 2021-06-09 15:24:48 +08:00 committed by Hans de Goede
parent a8aedd45d7
commit be9c4fa236
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/platform/surface/aggregator/ssh_packet_layer.c
View File

@ -1567,9 +1567,7 @@ static void ssh_ptl_timeout_reap(struct work_struct *work)
clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state); clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
atomic_dec(&ptl->pending.count); atomic_dec(&ptl->pending.count);
list_del(&p->pending_node); list_move_tail(&p->pending_node, &claimed);
list_add_tail(&p->pending_node, &claimed);
} }
spin_unlock(&ptl->pending.lock); spin_unlock(&ptl->pending.lock);
@ -1957,8 +1955,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
smp_mb__before_atomic(); smp_mb__before_atomic();
clear_bit(SSH_PACKET_SF_QUEUED_BIT, &p->state); clear_bit(SSH_PACKET_SF_QUEUED_BIT, &p->state);
list_del(&p->queue_node); list_move_tail(&p->queue_node, &complete_q);
list_add_tail(&p->queue_node, &complete_q);
} }
spin_unlock(&ptl->queue.lock); spin_unlock(&ptl->queue.lock);
@ -1970,8 +1967,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl)
smp_mb__before_atomic(); smp_mb__before_atomic();
clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state); clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state);
list_del(&p->pending_node); list_move_tail(&p->pending_node, &complete_q);
list_add_tail(&p->pending_node, &complete_q);
} }
atomic_set(&ptl->pending.count, 0); atomic_set(&ptl->pending.count, 0);
spin_unlock(&ptl->pending.lock); spin_unlock(&ptl->pending.lock);