USB: gadget: Use memdup_user
Use memdup_user when user data is immediately copied into the allocated region. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; position p; identifier l1,l2; @@ - to = \(kmalloc@p\|kzalloc@p\)(size,flag); + to = memdup_user(from,size); if ( - to==NULL + IS_ERR(to) || ...) { <+... when != goto l1; - -ENOMEM + PTR_ERR(to) ...+> } - if (copy_from_user(to, from, size) != 0) { - <+... when != goto l2; - -EFAULT - ...+> - } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
37cd681c02
commit
be8a058b50
|
@ -1867,13 +1867,9 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
|
||||||
buf += 4;
|
buf += 4;
|
||||||
length -= 4;
|
length -= 4;
|
||||||
|
|
||||||
kbuf = kmalloc (length, GFP_KERNEL);
|
kbuf = memdup_user(buf, length);
|
||||||
if (!kbuf)
|
if (IS_ERR(kbuf))
|
||||||
return -ENOMEM;
|
return PTR_ERR(kbuf);
|
||||||
if (copy_from_user (kbuf, buf, length)) {
|
|
||||||
kfree (kbuf);
|
|
||||||
return -EFAULT;
|
|
||||||
}
|
|
||||||
|
|
||||||
spin_lock_irq (&dev->lock);
|
spin_lock_irq (&dev->lock);
|
||||||
value = -EINVAL;
|
value = -EINVAL;
|
||||||
|
|
Loading…
Reference in New Issue