mm/mempolicy: unify the create() func for bind/interleave/prefer-many policies
As they all do the same thing: sanity check and save nodemask info, create one mpol_new_nodemask() to reduce redundancy. Link: https://lkml.kernel.org/r/1627970362-61305-6-git-send-email-feng.tang@intel.com Signed-off-by: Feng Tang <feng.tang@intel.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Ben Widawsky <ben.widawsky@intel.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: David Rientjes <rientjes@google.com> Cc: Huang Ying <ying.huang@intel.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Michal Hocko <mhocko@kernel.org> Cc: Mike Kravetz <mike.kravetz@oracle.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
a38a59fdfa
commit
be897d48a9
|
@ -192,7 +192,7 @@ static void mpol_relative_nodemask(nodemask_t *ret, const nodemask_t *orig,
|
|||
nodes_onto(*ret, tmp, *rel);
|
||||
}
|
||||
|
||||
static int mpol_new_interleave(struct mempolicy *pol, const nodemask_t *nodes)
|
||||
static int mpol_new_nodemask(struct mempolicy *pol, const nodemask_t *nodes)
|
||||
{
|
||||
if (nodes_empty(*nodes))
|
||||
return -EINVAL;
|
||||
|
@ -210,22 +210,6 @@ static int mpol_new_preferred(struct mempolicy *pol, const nodemask_t *nodes)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int mpol_new_preferred_many(struct mempolicy *pol, const nodemask_t *nodes)
|
||||
{
|
||||
if (nodes_empty(*nodes))
|
||||
return -EINVAL;
|
||||
pol->nodes = *nodes;
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int mpol_new_bind(struct mempolicy *pol, const nodemask_t *nodes)
|
||||
{
|
||||
if (nodes_empty(*nodes))
|
||||
return -EINVAL;
|
||||
pol->nodes = *nodes;
|
||||
return 0;
|
||||
}
|
||||
|
||||
/*
|
||||
* mpol_set_nodemask is called after mpol_new() to set up the nodemask, if
|
||||
* any, for the new policy. mpol_new() has already validated the nodes
|
||||
|
@ -405,7 +389,7 @@ static const struct mempolicy_operations mpol_ops[MPOL_MAX] = {
|
|||
.rebind = mpol_rebind_default,
|
||||
},
|
||||
[MPOL_INTERLEAVE] = {
|
||||
.create = mpol_new_interleave,
|
||||
.create = mpol_new_nodemask,
|
||||
.rebind = mpol_rebind_nodemask,
|
||||
},
|
||||
[MPOL_PREFERRED] = {
|
||||
|
@ -413,14 +397,14 @@ static const struct mempolicy_operations mpol_ops[MPOL_MAX] = {
|
|||
.rebind = mpol_rebind_preferred,
|
||||
},
|
||||
[MPOL_BIND] = {
|
||||
.create = mpol_new_bind,
|
||||
.create = mpol_new_nodemask,
|
||||
.rebind = mpol_rebind_nodemask,
|
||||
},
|
||||
[MPOL_LOCAL] = {
|
||||
.rebind = mpol_rebind_default,
|
||||
},
|
||||
[MPOL_PREFERRED_MANY] = {
|
||||
.create = mpol_new_preferred_many,
|
||||
.create = mpol_new_nodemask,
|
||||
.rebind = mpol_rebind_preferred,
|
||||
},
|
||||
};
|
||||
|
|
Loading…
Reference in New Issue