drm/i915: Only show debug for state changes when banning
Since we trigger 10,000s of hangs and resets during selftesting, we emit
many, many thousands of lines of useless debug messages. Reduce the
frequency by only logging a change in state of a guilty context.
Fixes: 14921f3cef
("drm/i915: Fix context ban and hang accounting for client")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180618073135.10849-1-chris@chris-wilson.co.uk
This commit is contained in:
parent
02f361f5fd
commit
bcc2661e32
|
@ -2976,16 +2976,16 @@ static void i915_gem_context_mark_guilty(struct i915_gem_context *ctx)
|
||||||
score = atomic_add_return(CONTEXT_SCORE_GUILTY, &ctx->ban_score);
|
score = atomic_add_return(CONTEXT_SCORE_GUILTY, &ctx->ban_score);
|
||||||
banned = score >= CONTEXT_SCORE_BAN_THRESHOLD;
|
banned = score >= CONTEXT_SCORE_BAN_THRESHOLD;
|
||||||
|
|
||||||
DRM_DEBUG_DRIVER("context %s: guilty %d, score %u, ban %s\n",
|
|
||||||
ctx->name, atomic_read(&ctx->guilty_count),
|
|
||||||
score, yesno(banned && bannable));
|
|
||||||
|
|
||||||
/* Cool contexts don't accumulate client ban score */
|
/* Cool contexts don't accumulate client ban score */
|
||||||
if (!bannable)
|
if (!bannable)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
if (banned)
|
if (banned) {
|
||||||
|
DRM_DEBUG_DRIVER("context %s: guilty %d, score %u, banned\n",
|
||||||
|
ctx->name, atomic_read(&ctx->guilty_count),
|
||||||
|
score);
|
||||||
i915_gem_context_set_banned(ctx);
|
i915_gem_context_set_banned(ctx);
|
||||||
|
}
|
||||||
|
|
||||||
if (!IS_ERR_OR_NULL(ctx->file_priv))
|
if (!IS_ERR_OR_NULL(ctx->file_priv))
|
||||||
i915_gem_client_mark_guilty(ctx->file_priv, ctx);
|
i915_gem_client_mark_guilty(ctx->file_priv, ctx);
|
||||||
|
|
Loading…
Reference in New Issue