UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

dw_dmac: change dev_crit to dev_WARN in dwc_handle_error 

In case of handling a bad descriptor the dwc_handle_error() will dump a stack
as well. It's a lot more verbose and more likely to get user's attention.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
This commit is contained in:
Andy Shevchenko 2012-10-18 17:34:11 +03:00 committed by Vinod Koul
parent 6168d5670b
commit ba84bd7146
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/dw_dmac.c
View File

@ -485,14 +485,14 @@ static void dwc_handle_error(struct dw_dma *dw, struct dw_dma_chan *dwc)
dwc_dostart(dwc, dwc_first_active(dwc)); dwc_dostart(dwc, dwc_first_active(dwc));
/* /*
* KERN_CRITICAL may seem harsh, but since this only happens * WARN may seem harsh, but since this only happens
* when someone submits a bad physical address in a * when someone submits a bad physical address in a
* descriptor, we should consider ourselves lucky that the * descriptor, we should consider ourselves lucky that the
* controller flagged an error instead of scribbling over * controller flagged an error instead of scribbling over
* random memory locations. * random memory locations.
*/ */
dev_crit(chan2dev(&dwc->chan), "Bad descriptor submitted for DMA!\n"); dev_WARN(chan2dev(&dwc->chan), "Bad descriptor submitted for DMA!\n"
dev_crit(chan2dev(&dwc->chan), " cookie: %d\n", bad_desc->txd.cookie); " cookie: %d\n", bad_desc->txd.cookie);
dwc_dump_lli(dwc, &bad_desc->lli); dwc_dump_lli(dwc, &bad_desc->lli);
list_for_each_entry(child, &bad_desc->tx_list, desc_node) list_for_each_entry(child, &bad_desc->tx_list, desc_node)
dwc_dump_lli(dwc, &child->lli); dwc_dump_lli(dwc, &child->lli);