xfs: remove some stale comments from the log code

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:
Dave Chinner 2020-03-25 18:18:24 -07:00 committed by Darrick J. Wong
parent 3c702f9590
commit b843299ba5
1 changed files with 13 additions and 46 deletions

View File

@ -463,14 +463,6 @@ out_error:
return error; return error;
} }
/*
* NOTES:
*
* 1. currblock field gets updated at startup and after in-core logs
* marked as with WANT_SYNC.
*/
static bool static bool
__xlog_state_release_iclog( __xlog_state_release_iclog(
struct xlog *log, struct xlog *log,
@ -1915,7 +1907,7 @@ xlog_dealloc_log(
log->l_mp->m_log = NULL; log->l_mp->m_log = NULL;
destroy_workqueue(log->l_ioend_workqueue); destroy_workqueue(log->l_ioend_workqueue);
kmem_free(log); kmem_free(log);
} /* xlog_dealloc_log */ }
/* /*
* Update counters atomically now that memcpy is done. * Update counters atomically now that memcpy is done.
@ -2458,14 +2450,6 @@ next_lv:
return error; return error;
} }
/*****************************************************************************
*
* State Machine functions
*
*****************************************************************************
*/
static void static void
xlog_state_activate_iclog( xlog_state_activate_iclog(
struct xlog_in_core *iclog, struct xlog_in_core *iclog,
@ -2826,7 +2810,7 @@ xlog_state_done_syncing(
*/ */
wake_up_all(&iclog->ic_write_wait); wake_up_all(&iclog->ic_write_wait);
spin_unlock(&log->l_icloglock); spin_unlock(&log->l_icloglock);
xlog_state_do_callback(log); /* also cleans log */ xlog_state_do_callback(log);
} }
/* /*
@ -2946,13 +2930,14 @@ restart:
*logoffsetp = log_offset; *logoffsetp = log_offset;
return 0; return 0;
} /* xlog_state_get_iclog_space */ }
/* /*
* The first cnt-1 times through here we don't need to move the grant write head * The first cnt-1 times a ticket goes through here we don't need to move the
* because the permanent reservation has reserved cnt times the unit amount. * grant write head because the permanent reservation has reserved cnt times the
* Release part of current permanent unit reservation and reset current * unit amount. Release part of current permanent unit reservation and reset
* reservation to be one units worth. Also move grant reservation head forward. * current reservation to be one units worth. Also move grant reservation head
* forward.
*/ */
void void
xfs_log_ticket_regrant( xfs_log_ticket_regrant(
@ -3034,12 +3019,8 @@ xfs_log_ticket_ungrant(
} }
/* /*
* Mark the current iclog in the ring as WANT_SYNC and move the current iclog * This routine will mark the current iclog in the ring as WANT_SYNC and move
* pointer to the next iclog in the ring. * the current iclog pointer to the next iclog in the ring.
*
* When called from xlog_state_get_iclog_space(), the exact size of the iclog
* has not yet been determined, all we know is that we have run out of space in
* the current iclog.
*/ */
STATIC void STATIC void
xlog_state_switch_iclogs( xlog_state_switch_iclogs(
@ -3084,7 +3065,7 @@ xlog_state_switch_iclogs(
} }
ASSERT(iclog == log->l_iclog); ASSERT(iclog == log->l_iclog);
log->l_iclog = iclog->ic_next; log->l_iclog = iclog->ic_next;
} /* xlog_state_switch_iclogs */ }
/* /*
* Write out all data in the in-core log as of this exact moment in time. * Write out all data in the in-core log as of this exact moment in time.
@ -3291,13 +3272,6 @@ xfs_log_force_lsn(
return ret; return ret;
} }
/*****************************************************************************
*
* TICKET functions
*
*****************************************************************************
*/
/* /*
* Free a used ticket when its refcount falls to zero. * Free a used ticket when its refcount falls to zero.
*/ */
@ -3454,13 +3428,6 @@ xlog_ticket_alloc(
return tic; return tic;
} }
/******************************************************************************
*
* Log debug routines
*
******************************************************************************
*/
#if defined(DEBUG) #if defined(DEBUG)
/* /*
* Make sure that the destination ptr is within the valid data region of * Make sure that the destination ptr is within the valid data region of
@ -3546,7 +3513,7 @@ xlog_verify_tail_lsn(
if (blocks < BTOBB(iclog->ic_offset) + 1) if (blocks < BTOBB(iclog->ic_offset) + 1)
xfs_emerg(log->l_mp, "%s: ran out of log space", __func__); xfs_emerg(log->l_mp, "%s: ran out of log space", __func__);
} }
} /* xlog_verify_tail_lsn */ }
/* /*
* Perform a number of checks on the iclog before writing to disk. * Perform a number of checks on the iclog before writing to disk.
@ -3649,7 +3616,7 @@ xlog_verify_iclog(
} }
ptr += sizeof(xlog_op_header_t) + op_len; ptr += sizeof(xlog_op_header_t) + op_len;
} }
} /* xlog_verify_iclog */ }
#endif #endif
/* /*