UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ceph: don't SetPageError on writepage errors 

We already mark the mapping in that case, and doing this can cause
false positives to occur at fsync time, as well as spurious read
errors.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Jeff Layton 2019-07-02 12:35:52 -04:00 committed by Ilya Dryomov
parent 131d7eb4fa
commit b72b13eb20
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/ceph/addr.c
View File

@ -573,7 +573,7 @@ static u64 get_writepages_data_length(struct inode *inode,
/* /*
* Write a single page, but leave the page locked. * Write a single page, but leave the page locked.
* *
* If we get a write error, set the page error bit, but still adjust the * If we get a write error, mark the mapping for error, but still adjust the
* dirty page accounting (i.e., page is no longer dirty). * dirty page accounting (i.e., page is no longer dirty).
*/ */
static int writepage_nounlock(struct page *page, struct writeback_control *wbc) static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
@ -648,7 +648,6 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
fsc->blacklisted = true; fsc->blacklisted = true;
dout("writepage setting page/mapping error %d %p\n", dout("writepage setting page/mapping error %d %p\n",
err, page); err, page);
SetPageError(page);
mapping_set_error(&inode->i_data, err); mapping_set_error(&inode->i_data, err);
wbc->pages_skipped++; wbc->pages_skipped++;
} else { } else {