UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: scsi_dh_alua: handle RTPG sense code correctly during state transitions 

Some arrays are not capable of returning RTPG data during state
transitioning, but rather return an 'LUN not accessible, asymmetric access
state transition' sense code. In these cases we can set the state to
'transitioning' directly and don't need to evaluate the RTPG data (which we
won't have anyway).

Link: https://lore.kernel.org/r/20191007135701.32389-1-hare@suse.de
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke 2019-10-07 15:57:01 +02:00 committed by Martin K. Petersen
parent 35a79a6351
commit b6ce6fb121
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/scsi/device_handler/scsi_dh_alua.c
View File

@ -511,6 +511,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
unsigned int tpg_desc_tbl_off; unsigned int tpg_desc_tbl_off;
unsigned char orig_transition_tmo; unsigned char orig_transition_tmo;
unsigned long flags; unsigned long flags;
bool transitioning_sense = false;
if (!pg->expiry) { if (!pg->expiry) {
unsigned long transition_tmo = ALUA_FAILOVER_TIMEOUT * HZ; unsigned long transition_tmo = ALUA_FAILOVER_TIMEOUT * HZ;
@ -571,13 +572,19 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
goto retry; goto retry;
} }
/* /*
* Retry on ALUA state transition or if any * If the array returns with 'ALUA state transition'
* UNIT ATTENTION occurred. * sense code here it cannot return RTPG data during
* transition. So set the state to 'transitioning' directly.
*/ */
if (sense_hdr.sense_key == NOT_READY && if (sense_hdr.sense_key == NOT_READY &&
sense_hdr.asc == 0x04 && sense_hdr.ascq == 0x0a) sense_hdr.asc == 0x04 && sense_hdr.ascq == 0x0a) {
err = SCSI_DH_RETRY; transitioning_sense = true;
else if (sense_hdr.sense_key == UNIT_ATTENTION) goto skip_rtpg;
}
/*
* Retry on any other UNIT ATTENTION occurred.
*/
if (sense_hdr.sense_key == UNIT_ATTENTION)
err = SCSI_DH_RETRY; err = SCSI_DH_RETRY;
if (err == SCSI_DH_RETRY && if (err == SCSI_DH_RETRY &&
pg->expiry != 0 && time_before(jiffies, pg->expiry)) { pg->expiry != 0 && time_before(jiffies, pg->expiry)) {
@ -665,7 +672,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
off = 8 + (desc[7] * 4); off = 8 + (desc[7] * 4);
} }
skip_rtpg:
spin_lock_irqsave(&pg->lock, flags); spin_lock_irqsave(&pg->lock, flags);
if (transitioning_sense)
pg->state = SCSI_ACCESS_STATE_TRANSITIONING;
sdev_printk(KERN_INFO, sdev, sdev_printk(KERN_INFO, sdev,
"%s: port group %02x state %c %s supports %c%c%c%c%c%c%c\n", "%s: port group %02x state %c %s supports %c%c%c%c%c%c%c\n",
ALUA_DH_NAME, pg->group_id, print_alua_state(pg->state), ALUA_DH_NAME, pg->group_id, print_alua_state(pg->state),