mm/damon/sysfs-schemes: implement DAMOS tried total bytes file
Patch series "mm/damon/sysfs-schemes: implement DAMOS tried total bytes file". The tried_regions directory of DAMON sysfs interface is useful for retrieving monitoring results snapshot or DAMOS debugging. However, for common use case that need to monitor only the total size of the scheme tried regions (e.g., monitoring working set size), the kernel overhead for directory construction and user overhead for reading the content could be high if the number of monitoring region is not small. This patchset implements DAMON sysfs files for efficient support of the use case. The first patch implements the sysfs file to reduce the user space overhead, and the second patch implements a command for reducing the kernel space overhead. The third patch adds a selftest for the new file, and following two patches update documents. [1] https://lore.kernel.org/damon/20230728201817.70602-1-sj@kernel.org/ This patch (of 5): The tried_regions directory can be used for retrieving the monitoring results snapshot for regions of specific access pattern, by setting the scheme's action as 'stat' and the access pattern as required. While the interface provides every detail of the monitoring results, some use cases including working set size monitoring requires only the total size of the regions. For such cases, users should read all the information and calculate the total size of the regions. However, it could incur high overhead if the number of regions is high. Add a file for retrieving only the information, namely 'total_bytes' file. It allows users to get the total size by reading only the file. Link: https://lkml.kernel.org/r/20230802213222.109841-1-sj@kernel.org Link: https://lkml.kernel.org/r/20230802213222.109841-2-sj@kernel.org Signed-off-by: SeongJae Park <sj@kernel.org> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Shuah Khan <shuah@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
parent
a3235ea2a8
commit
b69f92a741
|
@ -117,6 +117,7 @@ struct damon_sysfs_scheme_regions {
|
||||||
struct kobject kobj;
|
struct kobject kobj;
|
||||||
struct list_head regions_list;
|
struct list_head regions_list;
|
||||||
int nr_regions;
|
int nr_regions;
|
||||||
|
unsigned long total_bytes;
|
||||||
};
|
};
|
||||||
|
|
||||||
static struct damon_sysfs_scheme_regions *
|
static struct damon_sysfs_scheme_regions *
|
||||||
|
@ -128,9 +129,19 @@ damon_sysfs_scheme_regions_alloc(void)
|
||||||
regions->kobj = (struct kobject){};
|
regions->kobj = (struct kobject){};
|
||||||
INIT_LIST_HEAD(®ions->regions_list);
|
INIT_LIST_HEAD(®ions->regions_list);
|
||||||
regions->nr_regions = 0;
|
regions->nr_regions = 0;
|
||||||
|
regions->total_bytes = 0;
|
||||||
return regions;
|
return regions;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static ssize_t total_bytes_show(struct kobject *kobj,
|
||||||
|
struct kobj_attribute *attr, char *buf)
|
||||||
|
{
|
||||||
|
struct damon_sysfs_scheme_regions *regions = container_of(kobj,
|
||||||
|
struct damon_sysfs_scheme_regions, kobj);
|
||||||
|
|
||||||
|
return sysfs_emit(buf, "%lu\n", regions->total_bytes);
|
||||||
|
}
|
||||||
|
|
||||||
static void damon_sysfs_scheme_regions_rm_dirs(
|
static void damon_sysfs_scheme_regions_rm_dirs(
|
||||||
struct damon_sysfs_scheme_regions *regions)
|
struct damon_sysfs_scheme_regions *regions)
|
||||||
{
|
{
|
||||||
|
@ -148,7 +159,11 @@ static void damon_sysfs_scheme_regions_release(struct kobject *kobj)
|
||||||
kfree(container_of(kobj, struct damon_sysfs_scheme_regions, kobj));
|
kfree(container_of(kobj, struct damon_sysfs_scheme_regions, kobj));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static struct kobj_attribute damon_sysfs_scheme_regions_total_bytes_attr =
|
||||||
|
__ATTR_RO_MODE(total_bytes, 0400);
|
||||||
|
|
||||||
static struct attribute *damon_sysfs_scheme_regions_attrs[] = {
|
static struct attribute *damon_sysfs_scheme_regions_attrs[] = {
|
||||||
|
&damon_sysfs_scheme_regions_total_bytes_attr.attr,
|
||||||
NULL,
|
NULL,
|
||||||
};
|
};
|
||||||
ATTRIBUTE_GROUPS(damon_sysfs_scheme_regions);
|
ATTRIBUTE_GROUPS(damon_sysfs_scheme_regions);
|
||||||
|
@ -1648,6 +1663,7 @@ static int damon_sysfs_before_damos_apply(struct damon_ctx *ctx,
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
sysfs_regions = sysfs_schemes->schemes_arr[schemes_idx]->tried_regions;
|
sysfs_regions = sysfs_schemes->schemes_arr[schemes_idx]->tried_regions;
|
||||||
|
sysfs_regions->total_bytes += r->ar.end - r->ar.start;
|
||||||
region = damon_sysfs_scheme_region_alloc(r);
|
region = damon_sysfs_scheme_region_alloc(r);
|
||||||
list_add_tail(®ion->list, &sysfs_regions->regions_list);
|
list_add_tail(®ion->list, &sysfs_regions->regions_list);
|
||||||
sysfs_regions->nr_regions++;
|
sysfs_regions->nr_regions++;
|
||||||
|
@ -1678,6 +1694,7 @@ int damon_sysfs_schemes_clear_regions(
|
||||||
sysfs_scheme = sysfs_schemes->schemes_arr[schemes_idx++];
|
sysfs_scheme = sysfs_schemes->schemes_arr[schemes_idx++];
|
||||||
damon_sysfs_scheme_regions_rm_dirs(
|
damon_sysfs_scheme_regions_rm_dirs(
|
||||||
sysfs_scheme->tried_regions);
|
sysfs_scheme->tried_regions);
|
||||||
|
sysfs_scheme->tried_regions->total_bytes = 0;
|
||||||
}
|
}
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue