UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: dm9051: Fix use after free in dm9051_loop_tx() 

This code dereferences "skb" after calling dev_kfree_skb().

Fixes: 2dc95a4d30 ("net: Add dm9051 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220221105440.GA10045@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Dan Carpenter 2022-02-21 13:54:40 +03:00 committed by Jakub Kicinski
parent a0b92e0514
commit b6553c7181
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/davicom/dm9051.c
View File

@ -845,17 +845,19 @@ static int dm9051_loop_tx(struct board_info *db)
while (!skb_queue_empty(&db->txq)) {
struct sk_buff *skb;
unsigned int len;
skb = skb_dequeue(&db->txq);
if (skb) {
ntx++;
ret = dm9051_single_tx(db, skb->data, skb->len);
len = skb->len;
dev_kfree_skb(skb);
if (ret < 0) {
db->bc.tx_err_counter++;
return 0;
}
ndev->stats.tx_bytes += skb->len;
ndev->stats.tx_bytes += len;
ndev->stats.tx_packets++;
}