be2net: Drop redundant pci_enable_pcie_error_reporting()
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since f26e58bf6f
("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.
Remove the redundant pci_enable_pcie_error_reporting() call from the
driver. Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.
Note that this only controls ERR_* Messages from the device. An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
1de2a84dd0
commit
b4e24578b4
|
@ -16,7 +16,6 @@
|
|||
#include "be.h"
|
||||
#include "be_cmds.h"
|
||||
#include <asm/div64.h>
|
||||
#include <linux/aer.h>
|
||||
#include <linux/if_bridge.h>
|
||||
#include <net/busy_poll.h>
|
||||
#include <net/vxlan.h>
|
||||
|
@ -5726,8 +5725,6 @@ static void be_remove(struct pci_dev *pdev)
|
|||
be_unmap_pci_bars(adapter);
|
||||
be_drv_cleanup(adapter);
|
||||
|
||||
pci_disable_pcie_error_reporting(pdev);
|
||||
|
||||
pci_release_regions(pdev);
|
||||
pci_disable_device(pdev);
|
||||
|
||||
|
@ -5845,10 +5842,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
|
|||
goto free_netdev;
|
||||
}
|
||||
|
||||
status = pci_enable_pcie_error_reporting(pdev);
|
||||
if (!status)
|
||||
dev_info(&pdev->dev, "PCIe error reporting enabled\n");
|
||||
|
||||
status = be_map_pci_bars(adapter);
|
||||
if (status)
|
||||
goto free_netdev;
|
||||
|
@ -5893,7 +5886,6 @@ drv_cleanup:
|
|||
unmap_bars:
|
||||
be_unmap_pci_bars(adapter);
|
||||
free_netdev:
|
||||
pci_disable_pcie_error_reporting(pdev);
|
||||
free_netdev(netdev);
|
||||
rel_reg:
|
||||
pci_release_regions(pdev);
|
||||
|
|
Loading…
Reference in New Issue