UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

watchdog: renesas: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-25-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
This commit is contained in:
Uwe Kleine-König 2023-03-03 22:37:06 +01:00 committed by Wim Van Sebroeck
parent 6645579b70
commit b481d57bb1
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/watchdog/renesas_wdt.c
View File

@ -292,14 +292,12 @@ static int rwdt_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int rwdt_remove(struct platform_device *pdev) static void rwdt_remove(struct platform_device *pdev)
{ {
struct rwdt_priv *priv = platform_get_drvdata(pdev); struct rwdt_priv *priv = platform_get_drvdata(pdev);
watchdog_unregister_device(&priv->wdev); watchdog_unregister_device(&priv->wdev);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
static int __maybe_unused rwdt_suspend(struct device *dev) static int __maybe_unused rwdt_suspend(struct device *dev)
@ -339,7 +337,7 @@ static struct platform_driver rwdt_driver = {
.pm = &rwdt_pm_ops, .pm = &rwdt_pm_ops,
}, },
.probe = rwdt_probe, .probe = rwdt_probe,
.remove = rwdt_remove, .remove_new = rwdt_remove,
}; };
module_platform_driver(rwdt_driver); module_platform_driver(rwdt_driver);