UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

RDMA/efa: Be consistent with success flow return value 

The EFA driver is written with success oriented flows in mind, meaning
that functions should mostly end with a return 0 statement.
Error flows return their error value on their own instead of assuming
that the function will return the error at the end.

This commit fixes a bunch of functions that were not aligned with this
behavior.

Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Gal Pressman 2019-06-13 12:10:13 +03:00 committed by Doug Ledford
parent 40ddb3f020
commit b41f75724a
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/hw/efa/efa_com_cmd.c
View File

@ -56,7 +56,7 @@ int efa_com_create_qp(struct efa_com_dev *edev,
res->send_sub_cq_idx = cmd_completion.send_sub_cq_idx; res->send_sub_cq_idx = cmd_completion.send_sub_cq_idx;
res->recv_sub_cq_idx = cmd_completion.recv_sub_cq_idx; res->recv_sub_cq_idx = cmd_completion.recv_sub_cq_idx;
return err; return 0;
} }
int efa_com_modify_qp(struct efa_com_dev *edev, int efa_com_modify_qp(struct efa_com_dev *edev,
@ -178,7 +178,7 @@ int efa_com_create_cq(struct efa_com_dev *edev,
result->cq_idx = cmd_completion.cq_idx; result->cq_idx = cmd_completion.cq_idx;
result->actual_depth = params->cq_depth; result->actual_depth = params->cq_depth;
return err; return 0;
} }
int efa_com_destroy_cq(struct efa_com_dev *edev, int efa_com_destroy_cq(struct efa_com_dev *edev,

2
drivers/infiniband/hw/efa/efa_main.c
View File

@ -100,7 +100,7 @@ static int efa_request_mgmnt_irq(struct efa_dev *dev)
nr_cpumask_bits, &irq->affinity_hint_mask, irq->vector); nr_cpumask_bits, &irq->affinity_hint_mask, irq->vector);
irq_set_affinity_hint(irq->vector, &irq->affinity_hint_mask); irq_set_affinity_hint(irq->vector, &irq->affinity_hint_mask);
return err; return 0;
} }
static void efa_setup_mgmnt_irq(struct efa_dev *dev) static void efa_setup_mgmnt_irq(struct efa_dev *dev)

6
drivers/infiniband/hw/efa/efa_verbs.c
View File

@ -1594,15 +1594,17 @@ static int __efa_mmap(struct efa_dev *dev, struct efa_ucontext *ucontext,
err = -EINVAL; err = -EINVAL;
} }
if (err) if (err) {
ibdev_dbg( ibdev_dbg(
&dev->ibdev, &dev->ibdev,
"Couldn't mmap address[%#llx] length[%#llx] mmap_flag[%d] err[%d]\n", "Couldn't mmap address[%#llx] length[%#llx] mmap_flag[%d] err[%d]\n",
entry->address, length, entry->mmap_flag, err); entry->address, length, entry->mmap_flag, err);
return err; return err;
} }
return 0;
}
int efa_mmap(struct ib_ucontext *ibucontext, int efa_mmap(struct ib_ucontext *ibucontext,
struct vm_area_struct *vma) struct vm_area_struct *vma)
{ {