UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

x86, mce: drop BKL in mce_open 

BKL is not needed for anything in mce_open because it has
an own spinlock. Remove it.

[ Impact: cleanup ]

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
This commit is contained in:
Andi Kleen 2009-05-27 21:56:54 +02:00 committed by H. Peter Anvin
parent 32561696c2
commit b170204ddb
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/x86/kernel/cpu/mcheck/mce.c
View File

@ -13,7 +13,6 @@
#include <linux/ratelimit.h> #include <linux/ratelimit.h>
#include <linux/kallsyms.h> #include <linux/kallsyms.h>
#include <linux/rcupdate.h> #include <linux/rcupdate.h>
#include <linux/smp_lock.h>
#include <linux/kobject.h> #include <linux/kobject.h>
#include <linux/kdebug.h> #include <linux/kdebug.h>
#include <linux/kernel.h> #include <linux/kernel.h>
@ -791,12 +790,10 @@ static int open_exclu; /* already open exclusive? */
static int mce_open(struct inode *inode, struct file *file) static int mce_open(struct inode *inode, struct file *file)
{ {
lock_kernel();
spin_lock(&mce_state_lock); spin_lock(&mce_state_lock);
if (open_exclu || (open_count && (file->f_flags & O_EXCL))) { if (open_exclu || (open_count && (file->f_flags & O_EXCL))) {
spin_unlock(&mce_state_lock); spin_unlock(&mce_state_lock);
unlock_kernel();
return -EBUSY; return -EBUSY;
} }
@ -806,7 +803,6 @@ static int mce_open(struct inode *inode, struct file *file)
open_count++; open_count++;
spin_unlock(&mce_state_lock); spin_unlock(&mce_state_lock);
unlock_kernel();
return nonseekable_open(inode, file); return nonseekable_open(inode, file);
} }