UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: pm80xx: remove redundant assignments to variable rc 

There are several occasions where variable rc is being initialized with a
value that is never read and error is being re-assigned a little later on.
Clean up the code by removing rc entirely and just returning the return
value from the call to pm8001_issue_ssp_tmf

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Colin Ian King 2019-07-31 23:22:14 +01:00 committed by Martin K. Petersen
parent a5ac1f5d9a
commit afcd609e8e
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/scsi/pm8001/pm8001_sas.c
View File

@ -1308,28 +1308,22 @@ out:
int pm8001_abort_task_set(struct domain_device *dev, u8 *lun) int pm8001_abort_task_set(struct domain_device *dev, u8 *lun)
{ {
int rc = TMF_RESP_FUNC_FAILED;
struct pm8001_tmf_task tmf_task; struct pm8001_tmf_task tmf_task;
tmf_task.tmf = TMF_ABORT_TASK_SET; tmf_task.tmf = TMF_ABORT_TASK_SET;
rc = pm8001_issue_ssp_tmf(dev, lun, &tmf_task); return pm8001_issue_ssp_tmf(dev, lun, &tmf_task);
return rc;
} }
int pm8001_clear_aca(struct domain_device *dev, u8 *lun) int pm8001_clear_aca(struct domain_device *dev, u8 *lun)
{ {
int rc = TMF_RESP_FUNC_FAILED;
struct pm8001_tmf_task tmf_task; struct pm8001_tmf_task tmf_task;
tmf_task.tmf = TMF_CLEAR_ACA; tmf_task.tmf = TMF_CLEAR_ACA;
rc = pm8001_issue_ssp_tmf(dev, lun, &tmf_task); return pm8001_issue_ssp_tmf(dev, lun, &tmf_task);
return rc;
} }
int pm8001_clear_task_set(struct domain_device *dev, u8 *lun) int pm8001_clear_task_set(struct domain_device *dev, u8 *lun)
{ {
int rc = TMF_RESP_FUNC_FAILED;
struct pm8001_tmf_task tmf_task; struct pm8001_tmf_task tmf_task;
struct pm8001_device *pm8001_dev = dev->lldd_dev; struct pm8001_device *pm8001_dev = dev->lldd_dev;
struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev); struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev);
@ -1338,7 +1332,6 @@ int pm8001_clear_task_set(struct domain_device *dev, u8 *lun)
pm8001_printk("I_T_L_Q clear task set[%x]\n", pm8001_printk("I_T_L_Q clear task set[%x]\n",
pm8001_dev->device_id)); pm8001_dev->device_id));
tmf_task.tmf = TMF_CLEAR_TASK_SET; tmf_task.tmf = TMF_CLEAR_TASK_SET;
rc = pm8001_issue_ssp_tmf(dev, lun, &tmf_task); return pm8001_issue_ssp_tmf(dev, lun, &tmf_task);
return rc;
} }