scsi: sym53c8xx: Replace all non-returning strlcpy() with strscpy()
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Link: https://lore.kernel.org/r/20230530160323.412484-1-azeemshaikh38@gmail.com Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
dbe37c71d1
commit
af0ce90200
|
@ -1286,7 +1286,7 @@ static struct Scsi_Host *sym_attach(const struct scsi_host_template *tpnt, int u
|
|||
/*
|
||||
* Edit its name.
|
||||
*/
|
||||
strlcpy(np->s.chip_name, dev->chip.name, sizeof(np->s.chip_name));
|
||||
strscpy(np->s.chip_name, dev->chip.name, sizeof(np->s.chip_name));
|
||||
sprintf(np->s.inst_name, "sym%d", np->s.unit);
|
||||
|
||||
if ((SYM_CONF_DMA_ADDRESSING_MODE > 0) && (np->features & FE_DAC) &&
|
||||
|
|
Loading…
Reference in New Issue