vlan: update vlan carrier state for admin up/down
Currently, the VLAN event handler does not adjust the VLAN device's carrier state when the real device or the VLAN device is set administratively up or down. The following patch adds a transfer of operating state from the real device to the VLAN device when the real device is administratively set up or down, and sets the carrier state up or down during init, open and close of the VLAN device. This permits observers above the VLAN device that care about the carrier state (bonding's link monitor, for example) to receive updates for administrative changes by more closely mimicing the behavior of real devices. Signed-off-by: Jay Vosburgh <fubar@us.ibm.com> Signed-off-by: Patrick McHardy <kaber@trash.net>
This commit is contained in:
parent
1c41e238e0
commit
adc667e84f
|
@ -492,6 +492,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
|
|||
continue;
|
||||
|
||||
dev_change_flags(vlandev, flgs & ~IFF_UP);
|
||||
vlan_transfer_operstate(dev, vlandev);
|
||||
}
|
||||
break;
|
||||
|
||||
|
@ -507,6 +508,7 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
|
|||
continue;
|
||||
|
||||
dev_change_flags(vlandev, flgs | IFF_UP);
|
||||
vlan_transfer_operstate(dev, vlandev);
|
||||
}
|
||||
break;
|
||||
|
||||
|
|
|
@ -462,6 +462,7 @@ static int vlan_dev_open(struct net_device *dev)
|
|||
if (vlan->flags & VLAN_FLAG_GVRP)
|
||||
vlan_gvrp_request_join(dev);
|
||||
|
||||
netif_carrier_on(dev);
|
||||
return 0;
|
||||
|
||||
clear_allmulti:
|
||||
|
@ -471,6 +472,7 @@ del_unicast:
|
|||
if (compare_ether_addr(dev->dev_addr, real_dev->dev_addr))
|
||||
dev_unicast_delete(real_dev, dev->dev_addr, ETH_ALEN);
|
||||
out:
|
||||
netif_carrier_off(dev);
|
||||
return err;
|
||||
}
|
||||
|
||||
|
@ -492,6 +494,7 @@ static int vlan_dev_stop(struct net_device *dev)
|
|||
if (compare_ether_addr(dev->dev_addr, real_dev->dev_addr))
|
||||
dev_unicast_delete(real_dev, dev->dev_addr, dev->addr_len);
|
||||
|
||||
netif_carrier_off(dev);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -612,6 +615,8 @@ static int vlan_dev_init(struct net_device *dev)
|
|||
struct net_device *real_dev = vlan_dev_info(dev)->real_dev;
|
||||
int subclass = 0;
|
||||
|
||||
netif_carrier_off(dev);
|
||||
|
||||
/* IFF_BROADCAST|IFF_MULTICAST; ??? */
|
||||
dev->flags = real_dev->flags & ~(IFF_UP | IFF_PROMISC | IFF_ALLMULTI);
|
||||
dev->iflink = real_dev->ifindex;
|
||||
|
|
Loading…
Reference in New Issue