UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: scsi_error: DID_SOFT_ERROR comment clean up 

Updated comment. We are keeping track of maximum number of retries per
command via retries/allowed in struct scsi_cmnd. Corrected comment
positioning.

[mkp: applied by hand]

Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Petros Koutoupis 2017-10-30 16:38:10 -05:00 committed by Martin K. Petersen
parent e33d7c5645
commit ad95028a2e
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/scsi_error.c
View File

@ -1753,16 +1753,12 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
* that it indicates SUCCESS. * that it indicates SUCCESS.
*/ */
return SUCCESS; return SUCCESS;
case DID_SOFT_ERROR:
/* /*
* when the low level driver returns did_soft_error, * when the low level driver returns did_soft_error,
* it is responsible for keeping an internal retry counter * it is responsible for keeping an internal retry counter
* in order to avoid endless loops (db) * in order to avoid endless loops (db)
*
* actually this is a bug in this function here. we should
* be mindful of the maximum number of retries specified
* and not get stuck in a loop.
*/ */
case DID_SOFT_ERROR:
goto maybe_retry; goto maybe_retry;
case DID_IMM_RETRY: case DID_IMM_RETRY:
return NEEDS_RETRY; return NEEDS_RETRY;