UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

crypto: sun4i-ss - Fix PM reference leak when pm_runtime_get_sync() fails 

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Shixin Liu 2021-04-08 15:18:31 +08:00 committed by Herbert Xu
parent 1aa33c7a48
commit ac98fc5e1c
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c
View File

@ -561,7 +561,7 @@ int sun4i_ss_cipher_init(struct crypto_tfm *tfm)
sizeof(struct sun4i_cipher_req_ctx) + sizeof(struct sun4i_cipher_req_ctx) +
crypto_skcipher_reqsize(op->fallback_tfm)); crypto_skcipher_reqsize(op->fallback_tfm));
err = pm_runtime_get_sync(op->ss->dev); err = pm_runtime_resume_and_get(op->ss->dev);
if (err < 0) if (err < 0)
goto error_pm; goto error_pm;

2
drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c
View File

@ -454,7 +454,7 @@ static int sun4i_ss_probe(struct platform_device *pdev)
* this info could be useful * this info could be useful
*/ */
err = pm_runtime_get_sync(ss->dev); err = pm_runtime_resume_and_get(ss->dev);
if (err < 0) if (err < 0)
goto error_pm; goto error_pm;

2
drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c
View File

@ -27,7 +27,7 @@ int sun4i_hash_crainit(struct crypto_tfm *tfm)
algt = container_of(alg, struct sun4i_ss_alg_template, alg.hash); algt = container_of(alg, struct sun4i_ss_alg_template, alg.hash);
op->ss = algt->ss; op->ss = algt->ss;
err = pm_runtime_get_sync(op->ss->dev); err = pm_runtime_resume_and_get(op->ss->dev);
if (err < 0) if (err < 0)
return err; return err;

2
drivers/crypto/allwinner/sun4i-ss/sun4i-ss-prng.c
View File

@ -29,7 +29,7 @@ int sun4i_ss_prng_generate(struct crypto_rng *tfm, const u8 *src,
algt = container_of(alg, struct sun4i_ss_alg_template, alg.rng); algt = container_of(alg, struct sun4i_ss_alg_template, alg.rng);
ss = algt->ss; ss = algt->ss;
err = pm_runtime_get_sync(ss->dev); err = pm_runtime_resume_and_get(ss->dev);
if (err < 0) if (err < 0)
return err; return err;