drm/i915: Do the fbc vs. primary plane enable/disable in the right order
Disable fbc before disabling the primary plane, and enable fbc after the primary plane has been enabled again. Also use intel_disable_fbc() to disable FBC to avoid the pointless overhead of intel_update_fbc(), and especially avoid having to clean up and set up the stolen mem compressed buffer again. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
parent
098ebd6b7e
commit
abae50ed12
|
@ -526,11 +526,11 @@ intel_enable_primary(struct drm_crtc *crtc)
|
|||
|
||||
intel_crtc->primary_disabled = false;
|
||||
|
||||
I915_WRITE(reg, I915_READ(reg) | DISPLAY_PLANE_ENABLE);
|
||||
|
||||
mutex_lock(&dev->struct_mutex);
|
||||
intel_update_fbc(dev);
|
||||
mutex_unlock(&dev->struct_mutex);
|
||||
|
||||
I915_WRITE(reg, I915_READ(reg) | DISPLAY_PLANE_ENABLE);
|
||||
}
|
||||
|
||||
static void
|
||||
|
@ -544,13 +544,14 @@ intel_disable_primary(struct drm_crtc *crtc)
|
|||
if (intel_crtc->primary_disabled)
|
||||
return;
|
||||
|
||||
I915_WRITE(reg, I915_READ(reg) & ~DISPLAY_PLANE_ENABLE);
|
||||
|
||||
intel_crtc->primary_disabled = true;
|
||||
|
||||
mutex_lock(&dev->struct_mutex);
|
||||
intel_update_fbc(dev);
|
||||
if (dev_priv->fbc.plane == intel_crtc->plane)
|
||||
intel_disable_fbc(dev);
|
||||
mutex_unlock(&dev->struct_mutex);
|
||||
|
||||
I915_WRITE(reg, I915_READ(reg) & ~DISPLAY_PLANE_ENABLE);
|
||||
}
|
||||
|
||||
static int
|
||||
|
|
Loading…
Reference in New Issue