mm/swap: convert release_pages to use a folio internally
This function was already calling compound_head(), but now it can cache the result of calling compound_head() and avoid calling it again. Saves 299 bytes of text by avoiding various calls to compound_page() and avoiding checks of PageTail. Link: https://lkml.kernel.org/r/20220617175020.717127-14-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
parent
2397f780e1
commit
ab5e653ee8
34
mm/swap.c
34
mm/swap.c
|
@ -941,8 +941,7 @@ void release_pages(struct page **pages, int nr)
|
||||||
unsigned int lock_batch;
|
unsigned int lock_batch;
|
||||||
|
|
||||||
for (i = 0; i < nr; i++) {
|
for (i = 0; i < nr; i++) {
|
||||||
struct page *page = pages[i];
|
struct folio *folio = page_folio(pages[i]);
|
||||||
struct folio *folio = page_folio(page);
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Make sure the IRQ-safe lock-holding time does not get
|
* Make sure the IRQ-safe lock-holding time does not get
|
||||||
|
@ -954,35 +953,34 @@ void release_pages(struct page **pages, int nr)
|
||||||
lruvec = NULL;
|
lruvec = NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
page = &folio->page;
|
if (is_huge_zero_page(&folio->page))
|
||||||
if (is_huge_zero_page(page))
|
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
if (is_zone_device_page(page)) {
|
if (folio_is_zone_device(folio)) {
|
||||||
if (lruvec) {
|
if (lruvec) {
|
||||||
unlock_page_lruvec_irqrestore(lruvec, flags);
|
unlock_page_lruvec_irqrestore(lruvec, flags);
|
||||||
lruvec = NULL;
|
lruvec = NULL;
|
||||||
}
|
}
|
||||||
if (put_devmap_managed_page(page))
|
if (put_devmap_managed_page(&folio->page))
|
||||||
continue;
|
continue;
|
||||||
if (put_page_testzero(page))
|
if (folio_put_testzero(folio))
|
||||||
free_zone_device_page(page);
|
free_zone_device_page(&folio->page);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!put_page_testzero(page))
|
if (!folio_put_testzero(folio))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
if (PageCompound(page)) {
|
if (folio_test_large(folio)) {
|
||||||
if (lruvec) {
|
if (lruvec) {
|
||||||
unlock_page_lruvec_irqrestore(lruvec, flags);
|
unlock_page_lruvec_irqrestore(lruvec, flags);
|
||||||
lruvec = NULL;
|
lruvec = NULL;
|
||||||
}
|
}
|
||||||
__put_compound_page(page);
|
__put_compound_page(&folio->page);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (PageLRU(page)) {
|
if (folio_test_lru(folio)) {
|
||||||
struct lruvec *prev_lruvec = lruvec;
|
struct lruvec *prev_lruvec = lruvec;
|
||||||
|
|
||||||
lruvec = folio_lruvec_relock_irqsave(folio, lruvec,
|
lruvec = folio_lruvec_relock_irqsave(folio, lruvec,
|
||||||
|
@ -990,8 +988,8 @@ void release_pages(struct page **pages, int nr)
|
||||||
if (prev_lruvec != lruvec)
|
if (prev_lruvec != lruvec)
|
||||||
lock_batch = 0;
|
lock_batch = 0;
|
||||||
|
|
||||||
del_page_from_lru_list(page, lruvec);
|
lruvec_del_folio(lruvec, folio);
|
||||||
__clear_page_lru_flags(page);
|
__folio_clear_lru_flags(folio);
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
@ -1000,13 +998,13 @@ void release_pages(struct page **pages, int nr)
|
||||||
* found set here. This does not indicate a problem, unless
|
* found set here. This does not indicate a problem, unless
|
||||||
* "unevictable_pgs_cleared" appears worryingly large.
|
* "unevictable_pgs_cleared" appears worryingly large.
|
||||||
*/
|
*/
|
||||||
if (unlikely(PageMlocked(page))) {
|
if (unlikely(folio_test_mlocked(folio))) {
|
||||||
__ClearPageMlocked(page);
|
__folio_clear_mlocked(folio);
|
||||||
dec_zone_page_state(page, NR_MLOCK);
|
zone_stat_sub_folio(folio, NR_MLOCK);
|
||||||
count_vm_event(UNEVICTABLE_PGCLEARED);
|
count_vm_event(UNEVICTABLE_PGCLEARED);
|
||||||
}
|
}
|
||||||
|
|
||||||
list_add(&page->lru, &pages_to_free);
|
list_add(&folio->lru, &pages_to_free);
|
||||||
}
|
}
|
||||||
if (lruvec)
|
if (lruvec)
|
||||||
unlock_page_lruvec_irqrestore(lruvec, flags);
|
unlock_page_lruvec_irqrestore(lruvec, flags);
|
||||||
|
|
Loading…
Reference in New Issue