UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

sched/fair: Remove unused return of _nohz_idle_balance 

The return of _nohz_idle_balance() is not used anymore so we can remove
it

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20210224133007.28644-3-vincent.guittot@linaro.org
This commit is contained in:
Vincent Guittot 2021-02-24 14:30:02 +01:00 committed by Ingo Molnar
parent 0826530de3
commit ab2dde5e98
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/sched/fair.c
View File

@ -10354,10 +10354,8 @@ out:
* Internal function that runs load balance for all idle cpus. The load balance * Internal function that runs load balance for all idle cpus. The load balance
* can be a simple update of blocked load or a complete load balance with * can be a simple update of blocked load or a complete load balance with
* tasks movement depending of flags. * tasks movement depending of flags.
* The function returns false if the loop has stopped before running
* through all idle CPUs.
*/ */
static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags,
enum cpu_idle_type idle) enum cpu_idle_type idle)
{ {
/* Earliest time when we have to do rebalance again */ /* Earliest time when we have to do rebalance again */
@ -10367,7 +10365,6 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags,
int update_next_balance = 0; int update_next_balance = 0;
int this_cpu = this_rq->cpu; int this_cpu = this_rq->cpu;
int balance_cpu; int balance_cpu;
int ret = false;
struct rq *rq; struct rq *rq;
SCHED_WARN_ON((flags & NOHZ_KICK_MASK) == NOHZ_BALANCE_KICK); SCHED_WARN_ON((flags & NOHZ_KICK_MASK) == NOHZ_BALANCE_KICK);
@ -10447,15 +10444,10 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags,
WRITE_ONCE(nohz.next_blocked, WRITE_ONCE(nohz.next_blocked,
now + msecs_to_jiffies(LOAD_AVG_PERIOD)); now + msecs_to_jiffies(LOAD_AVG_PERIOD));
/* The full idle balance loop has been done */
ret = true;
abort: abort:
/* There is still blocked load, enable periodic update */ /* There is still blocked load, enable periodic update */
if (has_blocked_load) if (has_blocked_load)
WRITE_ONCE(nohz.has_blocked, 1); WRITE_ONCE(nohz.has_blocked, 1);
return ret;
} }
/* /*