ipmi: ipmi_si_hardcode.c: init si_type array to fix a crash
The intended behavior of function ipmi_hardcode_init_one() is to default to kcs interface when no type argument is presented when initializing ipmi with hard coded addresses. However, the array of char pointers allocated on the stack by function ipmi_hardcode_init() was not inited to zeroes, so it contained stack debris. Consequently, passing the cruft stored in this array to function ipmi_hardcode_init_one() caused a crash when it was unable to detect that the char * being passed was nonsense and tried to access the address specified by the bogus pointer. The fix is simply to initialize the si_type array to zeroes, so if there were no type argument given to at the command line, function ipmi_hardcode_init_one() could properly default to the kcs interface. Signed-off-by: Tony Camuso <tcamuso@redhat.com> Message-Id: <1554837603-40299-1-git-send-email-tcamuso@redhat.com> Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
parent
bd2e98b351
commit
a885bcfd15
|
@ -118,6 +118,8 @@ void __init ipmi_hardcode_init(void)
|
||||||
char *str;
|
char *str;
|
||||||
char *si_type[SI_MAX_PARMS];
|
char *si_type[SI_MAX_PARMS];
|
||||||
|
|
||||||
|
memset(si_type, 0, sizeof(si_type));
|
||||||
|
|
||||||
/* Parse out the si_type string into its components. */
|
/* Parse out the si_type string into its components. */
|
||||||
str = si_type_str;
|
str = si_type_str;
|
||||||
if (*str != '\0') {
|
if (*str != '\0') {
|
||||||
|
|
Loading…
Reference in New Issue